DEV Community

loading...
Cover image for Code Smell 58 - Yo-yo Problem

Code Smell 58 - Yo-yo Problem

Maxi Contieri
Learn something new every day. - I am a senior software engineer working in industry, teaching and writing on software design, SOLID principles, DDD and TDD.
・1 min read

Searching for a concrete method implementation? Go back and forth, up and down.

Problems

  • Deep Hierarchies

  • Subclassification for Code Reuse

  • Readability

  • Low Cohesion

  • High Coupling

Solutions

  1. Favor composition over inheritance.

  2. Refactor deep hierarchies.

Sample Code

Wrong

Right

Detection

Any linter can check for suspects against a max depth threshold.

Tags

  • Hierarchy

Conclusion

Many novice programmers reuse code through hierarchies. This brings high coupled and low cohesive hierarchies.

Johnson and Foote established in their paper this was actually a good design recipe back in 1988. We have learned a lot from there.

We must refactor and flatten those classes.

Relations

More info

Wikipedia

Coupling Problem

c2

Hierarchies should be deep by Johnson and Foote


An error arises from treating object variables (instance variables) as if they were data attributes and then creating your hierarchy based on shared attributes. Always create hierarchies based on shared behaviors, side.

David West

Discussion (0)