You have a clear responsibility for the wrong object

TL;DR: Don't be afraid to create or overload the proper objects.

Problems

• Bijection Fault.

Solutions

1. Find actual behavior on the real objects using the MAPPER.

2. Answer the question: 'Whose responsibility is..?'

Context

Finding responsible objects is a tough task.

If we talk to anybody outside the software world, they will tell us where we should place every responsibility.

Software engineers, on the contrary, tend to put behavior in strange places like helpers.

Sample Code

Wrong

function add(a, b) {
  return a + b;
}
// this is natural in many programming languages,
// but unnatural in real life

class GraphicEditor {
  constructor() {
    this.PI = 3.14;
    // We shouldn't define it here
  }

  pi() {
    return this.PI;
    // Not this object responsibility
  }

  drawCircle(radius) {
    console.log(`Drawing a circle with radius ${radius}
    and circumference ${2 * this.pi() * radius}.`);
  }
}

Right

class Integer {

  function add(adder) {
    return this + adder;
  }
}
// This won't compile in many programming languages
// But it is the right place for adding responsibility

class GraphicEditor {
  drawCircle(radius) {
    console.log(`Drawing a circle with radius ${radius} 
    and circumference ${2 * Number.pi() * radius}.`);
  }
}
// PI's definition is Number's responsibility

Detection

[X] Manual

This is a semantic smell.

Exceptions

• Some languages force you to add protocol in some objects and not on everyone (like primitive integers, Strings, Arrays, etc.)

Tags

• Behavior

Conclusion

If you put the responsibilities in the proper object, you will surely find them in the same place.

Relations

Code Smell 22 - Helpers

Maxi Contieri ・ Nov 12 '20

#oop #helpers #codenewbie #beginners

Code Smell 63 - Feature Envy

Maxi Contieri ・ Mar 23 '21

#codenewbie #programming #oop #webdev

More Info

• Clean Code Book

Disclaimer

Code Smells are just my opinion.

Credits

Photo by Austin Neill on Unsplash

We know an object by what it does, by what services it can provide. That is to say, we know objects by their behaviors.

David West

Software Engineering Great Quotes

Maxi Contieri ・ Dec 28 '20

#codenewbie #programming #quotes #software

This article is part of the CodeSmell Series.

How to Find the Stinky parts of your Code

Maxi Contieri ・ May 21 '21

#codenewbie #tutorial #codequality #beginners