Originally published at iamdeveloper.com
Like many of you, I am participating in Hacktoberfest as well. Most of the contributions I have made in October have been for DEV. Here are the PRs that have been merged so far:
Mini refactor to make variable names clearer in the Categories component #4257
What type of PR is this? (check all applicable)
- [x] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] Documentation Update
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
- [ ] docs.dev.to
- [ ] readme
- [x] no documentation needed
[optional] What gif best describes this PR or how it makes you feel?
Now eslint ignores the app/assets/javascripts/lib folder. #4323
What type of PR is this? (check all applicable)
- [x] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] Documentation Update
Description
The app/assets/javascripts/lib
should be completely ignored by eslint as it is a folder that contains 3rd party libs, e.g. pulltorefresh.js and xss.js
This PR adds that entire folder to eslint's ignore list.
Related Tickets & Documents
#3777
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
- [ ] docs.dev.to
- [ ] readme
- [x] no documentation needed
[optional] What gif best describes this PR or how it makes you feel?
VS Code Settings Update / Frontend Debug Documentation #4346
What type of PR is this? (check all applicable)
- [ ] Refactor
- [ ] Feature
- [ ] Bug Fix
- [x] Documentation Update
Description
This PR adds a section to the frontend documentation for debugging. It also includes a debug configuration for Edge for VS Code.
I am happy to change the wording if necessary or feel free to commit a change directly to this PR.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
- [x] docs.dev.to
- [ ] readme
- [ ] no documentation needed
[optional] What gif best describes this PR or how it makes you feel?
Fixed a typo #4374
What type of PR is this? (check all applicable)
- [ ] Refactor
- [ ] Feature
- [ ] Bug Fix
- [x] Documentation Update
Description
Fixed a typo
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
- [x] docs.dev.to
- [ ] readme
- [ ] no documentation needed
[optional] What gif best describes this PR or how it makes you feel?
The other PR that is still under review got merged is for the learnstorybook.com website.
chromaui / learnstorybook.com
Static site and content for Storybook tutorials
Learn Storybook
Learn Storybook teaches you how to use Storybook and Component-Driven Development to build UIs from scratch. We walk through core concepts from building and testing to deployment. Using engaging guides and content, we hope to get you up to speed on Storybook best practices in a fast and approachable way.
Who made LearnStorybook.com?
The text, code, and production were contributed by Chromatic. The tutorial was inspired by Chromatic’s popular GraphQL + React tutorial series
Contributors
- Tom Coleman @tmeasday
- Dominic Nguyen @domyen
- Carlos Iván Suarez @icarlossz
- Luciano M. Guasco @luchux
- yobrave
- Daniel Duan
- Carlos Vega
- Matt Rothenberg
- Kyle Holmberg
- You? Become an OSS contributor
Contribute
Contributions to Learn Storybook are encouraged! If it’s something small like grammar, punctuation, or even a code snippet, first check the open pull requests to see if it's already being addressed, if it's not, then open up a pull request. If it’s a…
The PR adds a precommit hook to format markdown files via prettier and as well, I ran prettier on all the markdown files as a lot of files had not run through prettier previously.
All markdown files are properly formatted now #181
This PR implements #162, and adds a precommit hook via lint-staged and husky. For the time being, I have only added an entry to lint-staged to format markdown (md) files. As well, all the md files have been formatted using the prettier settings that I copied from Storybook's settings.
Built everything locally and it looks good. I just did a smoke test navigating to some pages.
Also, Skeletor approves of this PR.
Although this is not from Hacktoberfest, the beauty of open source is that anyone can checkout what you are up to. I was super surprised and felt pretty good when Addy Osmani liked one of my PRs for DEV.
I will probably contribute some more to the DEV codebase, but who knows, I may tackle an issue in another repository. YOLO.
Top comments (2)
Good job!
Nice to see some documentation/refactoring PRs - in my experience those issues don't get enough dev-love :)
It's awesome Nick!