For my release 0.3 for OSD600, I have to create a pull request for an internal Seneca College open-source project. The repo I contributed to was my-photohub.
My pull request
My pull request involved moving some auto-generated documentation from the top of a file into the contributing document. After submitting my pull request, I was asked to make some changes by a contributor. This involved making some script arguments more generic. After this, more contributors reviewed my pull request before it was merged into the project.
What I learned
From this pull request, along with actually making code reviews, I learned more about how the code review process worked. Previously, I had only worked on repos that were managed by a single author. However, this is the first time I have created a pull request reviewed by multiple people. This is also the first time I had changes requested for my pull request. I feel like integrating requested changes was quite simple as those who are requesting changes will often provide good guidance on how to make those changes.
Top comments (0)