DEV Community

Vivian
Vivian

Posted on

OSD600 - Doing Code Reviews

1. Introduction

For reviewing, I did code reviews for 3 other students pull requests on the IPC144 repo. Since I also work on auditing and fixing markdown file, when I check their works I might find out what I have missed to fix for my task.

2. The first issue

The first issue I found were pretty minor. It is almost about some address values were forgot to be wrapped in backticks. Other issues in the repos were addressed well by the contributors or found by other reviewers. PR1 PR2

3. The second issue

The second issue is the redundancy of whitespace in source code. This makes the source code's style become inconsistent. Sometimes, if there is a redundant whitespace before bullet point it will produce different result than we expected. PR3

4. Overall

The review process was very enjoyable. Many people work on the same task will make it be perfect and error-free.

Top comments (0)