DEV Community

Neil An
Neil An

Posted on

Making another PR to a repo

Hi everyone,

This week I worked on Astro reactive library, a repo that I previously worked on for Hacktoberfest. Astro reactive library uses the Astro framework to let you build reactive user interfaces.

The issue was to add a setValue method to the FormGroup class. This would allow anyone using Astro to set the values of any form controls in that form group. For example:

Image description

should produce the following result:

Image description

Since I was familiar with this repo, I didn't have to learn the documentation. The first thing I did was find the file where I had to make my changes. After finding the file, I needed to figure out how I would implement the method. I looked in the form-control to see what properties each form control has and how I could use those properties in my implementation. I found that each form control has a name and value property that I could use. So, after figuring this out, I created my first implementation for the method. I also updated a demo page I created during Hacktoberfest to use the new method and submitted a PR.

The repo owner reviewed my PR and requested I make some changes, specifically to an ESLint error and to change my method implementation to be more efficient. After making the changes, they approved my PR and merged.

Top comments (0)