DEV Community

Discussion on: I broke master today.

Collapse
 
missamarakay profile image
Amara Graham

I broke production and despite really beating myself up over it, everyone immediately focused on the fact that it could have been anyone and we needed to fix the process so it wouldn't happen again.

So maybe just climb under the rock for like a single day? 🤗

Collapse
 
adam_cyclones profile image
Adam Crockett 🌀

Thank you Amara, I got a response something like that, I broke it then merged a quick fix. So we shall see what happens.

I feel like I have reverted to a junior developer so far it's terrible, I can be much more cautious and thoughtful than I have been. I think I need to calm down and gain back some trust.

Collapse
 
missamarakay profile image
Amara Graham

No one ever stops making mistakes, no matter how senior their title. The important part is learning from it, acknowledging it, and correcting the process.

Collapse
 
deciduously profile image
Ben Lovy

I'm no professional but this is always my takeaway when I hear stories like this - it shouldn't be so easy to break in the first place. This indicates a problem with the whole process, not a problem with any individual, and represents an opportunity to improve.

Collapse
 
adam_cyclones profile image
Adam Crockett 🌀

Well I had thought maybe there could be a precommit hook to run lint. We used to have this in my old job, and I honestly forgot we don't here.

Thread Thread
 
deciduously profile image
Ben Lovy

Are you in a position to propose such a hook?

Thread Thread
 
adam_cyclones profile image
Adam Crockett 🌀

I can just do it, but I will propose it yeah 😁