DEV Community

Why can't you break out of the forEach loop?

mayankav on September 29, 2021

This is one of the many things I keep forgetting every now and then. Other things like taking out clothes from the washing machine, watering my pla...

Read full post

Jon Randy 🎖️ • Sep 29 '21 • Edited

You can throw an exception. Not the prettiest solution, but it works...

const BreakException = {}
try {
  [1, 2, 3].forEach(function(el) {
    console.log(el)
    if (el === 2) throw BreakException
  });
} catch (e) {
  if (e !== BreakException) throw e
}

Another way is to just use some and return a truthy from your function if you want to break out:

[1, 2, 3].every(function(el) {
   console.log(el)
   if (el===2) return true
})

lionel-rowe • Sep 30 '21

Why use an unreadable, hacky solution when for... of exists?

Jon Randy 🎖️ • Sep 30 '21

Many ways to skin a cat, couldn't be bothered to list them all

lionel-rowe • Sep 30 '21

What I'm saying is, if you care about code quality, why not use the best tool for the job?

Jon Randy 🎖️ • Sep 30 '21 • Edited

I care about code. I care about, and am interested in the many permutations that can achieve the same result - including all the weird and wonderful ways. To me, that's the beauty of code, and is why I love it. Correctness, readability, and quality are purely subjective. I personally cannot think of anything worse than blindly following the dogmatic methodologies promoted as the best, or right way to do things - without playing and enjoying exploring alternatives.

Writing code, from my perspective, is more like art crossed with science than engineering. It's a very personal thing - like writing a novel, or poetry, or painting a picture. There can very definitely be beauty in it.

This approach does inevitably clash with others who follow a more traditional software engineering route, but it has served me well over the 38 years I've been writing code.

lionel-rowe • Sep 30 '21

I sympathize with that approach for sure, but I see it as similar to writing prose, which is certainly a creative endeavor. Sure, you could write an essay caPitALiZIng RAndOM leTtErs or spelıng uerds uıth ior oun ınventıd orthogr'fy, but who would want to read it, much less be your co-writer on it? There are conventions for a reason, and you should have an even better reason if you want to break them. That doesn't mean for a second that you can never break them — it just means that, for example, you should typically avoid adding complexity where you don't gain something (performance, flexibility, etc) of at least equal value in return.

Jon Randy 🎖️ • Sep 30 '21 • Edited

Have you read Cormac McCarthy's "The Road"? That won a Pullitzer prize, and would probably get you a fail from most school English teachers if you were to submit it, or something similar for a writing assignment.

Most of the best art is made by breaking or testing the rules to their limits. I much prefer to read code that is 'hard to reason about' than code that reads like a class reader for five year olds - it gives me pause to think and exercise my brain, and maybe lend new perspectives on ways to use code.

I think we'll have to agree to disagree

lionel-rowe • Sep 30 '21

I think we'll have to agree to disagree

That's fair.

mayankav • Sep 30 '21

Much appreciation to you both for the exchange of thoughts. I think playing around with the code and conventions is as important as keeping a shared repository clean and conventional. I like how Jon added his perspective to the post and I also agree with Lionel about readability when it comes to code in production. Cheers 🥂

mayankav • Sep 29 '21

@jonrandy Indeed Jon! This post doesn't cover the possible solutions for a reason. I found it easier to throw in an MDN link which covers some alternatives.

Conan • Sep 29 '21

Nice explanation as to why break won’t work by writing your own version of forEach.

I know you linked to some alternatives already and this is probably familiar, but here’s an example I popped together using some / every.

mayankav • Sep 30 '21

@shuckster I like what you did there on zansh.in

Przemyslaw Michalak • Sep 30 '21 • Edited

You can't break from forEach because that's the purpose of forEach loop. In JS you have reduce, map, while, do while, for, filter and god knows how many other types of loops. The reason for forEach to exist is to NOT allow you to break from it! It's like complaining that the sit belt in the car have a functionality of saving your life in the accident, well... that's the purpose, not a flaw.

mayankav • Sep 30 '21 • Edited

Hey man! appreciate the analogy. There can indeed be many more reasons why you'd go with a forEach loop (keeping variables scoped, clean abstraction etc..). Tbh, I dont really know the motivation(s) behind the creation of forEach in the first place but that hardly matters. This is just me pointing out a simple mistake that most of us make. I do this over and over even when I know the stuff.