DEV Community

Discussion on: What to review in a code review

Collapse
 
dularish profile image
Dularish

I would rather have my code reviewed by someone who has experienced a longer time with the codebase, because sometimes the logic I write to solve a particular problem was already solved in some refractored helper that is not obvious to you, or the same logic is written somewhere else, and these could be refractored in a suitable helper.

Collapse
 
tirthaguha profile image
Tirtha Guha

Agree, that knowledge about such utilities help, but that should not be a must have quality of the reviewer. Unless, of course, your codebase has legacy code or too much custom non-standard implementation.