Discussion on: The code review we deserve

So true, all of this. Somewhere, I found a number of tips for writing good code review comments. It containes phrases like

• What would happen if x were to become negative?
• this statement makes xyz become suchandso
• ...

Also, in a trusting team, you can

• Allow the reviewer to do small fixes themselves (and notify later) to save effort
• Just go talk about this or that issue
• Use a set of accepted 'tags' to indicate the severity of the comment (bug, performance, wtf, style,...)

Also, don't forget that a compliment goes a long way; (what an elegant way to..., ).

Indeed: scrutinous witchunt code reviews are medieval; code review is a great way to extend the team's capacities.