DEV Community

Async + Await refactor, which do you like best?

Wilbur Powery on May 18, 2018

Async + Await is sooo good once you get the hang of it. Just refactored this piece of code and removed a lot of indentation levels. Removing inden...

Read full post

Avalander • May 18 '18 • Edited

I don't think that async/await is a bad thing, but I like that Promises force you to think what parts of your code depend on which asynchronous data and to organise it accordingly. Async/await allows you to write asynchronous code like it is synchronous and I have mixed feelings about this.

It's worth mentioning that I don't use either, I usually use Fluture because it doesn't automagically catch all and every error in the rejection branch, which you can't achieve with async/await or Promises. But the Fluture API is quite similar to a Promise and I kind of like it.

Also, notice that if the goal is to remove indentation, there is no reason why the last then of the example on the left can't be rewritten as

.then(response => {
    this.updateEventValues()
    return this.Alert.success('Se ha actualizado el evento')
)
.then(() => this.clearEventAndClose())

Which has the additional benefit that if you need to catch any rejection, you only need to do it once.

Ben Halpern • May 19 '18

I agree with this logic

Erebos Manannán • Jul 11 '18

Neither is very good, as you're doing nothing to handle errors.

One requires .catch() in several places, the other a try { ... } catch (...) { ... } block or several.

Overall the await syntax is much easier to read and follow the logic, but if you have to put a try..catch around every one it quickly becomes a mess too.

Mihail Malo • Feb 8 '19

I often do the following:

await fallible().catch(errorHandler)

It allows me to pipe/sidechain my errors where they truly belong, instead of breaking up my happy path logic with inline implementation of the catch block OR lambda.
If I need to abort the current function, the handler will just rethrow.

Wilbur Powery • Jul 11 '18

Yeah, I agree. As with everything, you should choose carefully 😄

Maria Zaitseva • Aug 24 '18

I love async/await and and the same time I despise try/catch, so I tend to use .catch() method for error handling. Just looks neater. I wish I could do all exception handling that way.

xtofl • Sep 12 '18

i think, as a matter of fact, that you can do all error handling this way. The functional programming folks found that out and called the resulting pattern a Monad. Take a look at m.youtube.com/watch?v=Mw_Jnn_Y5iA#

Evaldas Buinauskas • May 20 '18

This is totally out of topic, but what font is this?

Wilbur Powery • May 20 '18

Operator Mono 😊

Mihail Malo • Feb 8 '19

HAHAHA they asked you this on twitter as well :v

Mihail Malo • Feb 8 '19

I think the async/await is a clear winner here, since these were 4 sequential operations, 2 of which just needed to yield yet still block the progress of this function, and cancel the function if they throw.
It's the textbook happy case for async/await.

I do agree with @avalander 's refactor though, which gets you closer to this without the async syntax.

01101001 • Jun 14 '18

i like async and await. Especially await :))