DEV Community

Discussion on: You (probably) don't need that useState + useEffect

View post
Collapse
 
webkadabra profile image
WEBKADABRA •

bro, the first code snippet has an error in it, I think:

useEffect(() => {
    setItems(data.items);
    setItems(data.items.length || 0);
  }, [data, setItems, setItemsLength]);
Enter fullscreen mode Exit fullscreen mode

Shoultd it not be this instead:

useEffect(() => {
    setItems(data.items);
    setItemsLength(data.items.length || 0);
  }, [data, setItems, setItemsLength]);
Enter fullscreen mode Exit fullscreen mode
Collapse
 
townofdon profile image
Don Juan Javier •

Good catch! Made the correction. Important to test first before sending off to QA 😅

Collapse
 
nvhung150196 profile image
nvhung150196 •

setState in React is stable. You should remove them from the dependency array. I think array just like this [data]