DEV Community

Tue
Tue

Posted on

Doing code reviews

This week, I had a chance to review some pull requests from different students in IPC144 repo.

Review #1

I did some reviews for this a PR on Information.md but the author ran into some technical issues, I tried to help him to resolve using git as I ran into the same issue as well, but he deleted his fork and tried opening new PRs. I pointed out some typo issues, markdown issues and his mistake committing an unresolved conflict. You can check them here, PR#1, PR#2, PR#3

Review #2

I pointed out an unnecessary section of the page of the PR on functions-arrays-and-structs.md and advised an accessibility improvement on this PR

My thoughts

Reviewing does take quite some time and great attention to details especially with those PRs. I did have some fun reading people's reviews and I learnt more about correct markdown syntaxes. I hope to review more challenging PRs next time.

Top comments (0)