DEV Community

Discussion on: Giving and Receiving Great Code Reviews

Collapse
 
t4rzsan profile image
Jakob Christensen • Edited

Great article. It made me change how to write commit messages.

But I wonder why you call it "imperative mood" (I am Danish so English is not my first language and I am quite possibly completely wrong)? Chris Beams writes in his blog that you should be able to use your commit message in the sentence "If applied, this commit will ...". But that is not imperative mood. That is called future tense (I think).

I don't think it actually makes a difference in English but in Danish grammar there is a difference in wording between imperative mood and in future tense. So now I am in doubt what is the best way to write commit messages :-).

Collapse
 
samjarman profile image
Sam Jarman 👨🏼‍💻

I'm no expert in english terms, but I use the "If applied, this commit will ...".

Generally, it means drop the "s"

"Change x" (Not "changes x")
"Add x to y" (Not "Adds x to y")