Great work! It looks really useful. One question, though. How often does Pierre check to see if the dependent issues are closed? Let's say my PR depends on rails/rails#523, but this issue is still open when I submit it. A couple of days pass, and the Rails issue is closed, does Pierre automatically change the status of my PR to OK? Does it check for the status periodically, and updates it on the next run?
To answer your question: No. Currently Pierre only checks upon two events: PR creation and comments (added or deleted). I thought about adding a feature similar to one Jenkins have, where it re-runs the tests if you add a comment with "Jenkins please". Also, based on similar features of other GitHub apps, that seems to be the preferred choice.
But feel free to open an issue requesting this feature, and we can talk about it on GitHub!
Having a cron job that periodically checks the status of the dependencies would be a great feature to add. If it would also notify the user that a dependent issue just got addressed, it would be great.
I feel like this feature should be part of the core of GitHub... 😕
The cron job is a possible solution, which would also require some sort of storage, which we haven't yet. I've created an issue for this, so that we can continue the discussion there and even start some development: github.com/alvarocavalcanti/pierre...
:)
I feel the same way about this being a GitHub feature...
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Great work! It looks really useful. One question, though. How often does Pierre check to see if the dependent issues are closed? Let's say my PR depends on rails/rails#523, but this issue is still open when I submit it. A couple of days pass, and the Rails issue is closed, does Pierre automatically change the status of my PR to OK? Does it check for the status periodically, and updates it on the next run?
Thanks!
Thanks, Patricio! I hope it proves to be useful!
To answer your question: No. Currently Pierre only checks upon two events: PR creation and comments (added or deleted). I thought about adding a feature similar to one Jenkins have, where it re-runs the tests if you add a comment with "Jenkins please". Also, based on similar features of other GitHub apps, that seems to be the preferred choice.
But feel free to open an issue requesting this feature, and we can talk about it on GitHub!
Cheers!
Having a cron job that periodically checks the status of the dependencies would be a great feature to add. If it would also notify the user that a dependent issue just got addressed, it would be great.
I feel like this feature should be part of the core of GitHub... 😕
The cron job is a possible solution, which would also require some sort of storage, which we haven't yet. I've created an issue for this, so that we can continue the discussion there and even start some development: github.com/alvarocavalcanti/pierre...
:)
I feel the same way about this being a GitHub feature...