DEV Community

SMAmmar
SMAmmar

Posted on

Improving Web Portfolio

Hello guys, I just created this portfolio recently. The issue I am facing is that when you click the hamburger icon, a portrait overlay should appear on the left-hand side, but it is not showing.
I would like the help of my fellow DEVIAN's.
Here is the link to my Github repository.
https://github.com/SMAmmar/my_portfolio

Here is the deployed version link
https://smammar.github.io/my_portfolio/

Top comments (5)

Collapse
 
ankitbeniwal profile image
Ankit Beniwal

Hey,

I just opened a PR with the correction. It's working now.

Collapse
 
smammar profile image
SMAmmar

can you tell me what correction you made, and where?

Collapse
 
ankitbeniwal profile image
Ankit Beniwal

Yes. In main.js, the definition of toggle function had this line:
menuBranding.classList.add("close");

I just changed the class 'close' to 'show', making it:
menuBranding.classList.add("show");

Everything else was perfect.

Thread Thread
 
smammar profile image
SMAmmar

Thanks, bro, It worked. <3

Thread Thread
 
ankitbeniwal profile image
Ankit Beniwal

That's nothing.