Code review and pull requests can be a tense and awkward time. More often than not, you're not expecting too much feedback and certainly nothing too major. However, there are times where are issues in your code that need to be addressed. There are two ways forward here.
More code - a reviewer may point out parts of a feature you missed or conditional cases you forgot to account for. Add this code and try again.
More conversation - a perhaps better place to start would be to discuss the issues in the code. Being open to feedback and listening to the issues a reviewer is perceiving in your code. It's possible that the issue they've highlighted can be resolved with just conversation. Have it, then continue with the task at hand. Not every comment needs to mean code gets changed.
Heads up: As with any terse bit of advice, there will be exceptions of course, and subtleties and nuance that can't possibly be captured in a Byte of Wisdom. This has been what I've experienced, I'd love to hear yours in the comments too!
You can catch up with all the other bytes at http://bytesofwisdom.com/
Top comments (0)