While working on a story, I was asked to upgrade the openpgp Node dependency, but bad luck a lot of tests broke.
After digging a bit and implement the included changes the code was not compiling due to some issues with the types. I forgot to mention that I'm using TypeScript for this one. So many types were outdated so I decided to open a PR to the types library DefinitelyTyped. Here's the PR:
Update openpgp type definitions to support async functions
#30351
po5i
posted on
Please fill in this template.
- [x] Use a meaningful title for the pull request. Include the name of the package modified.
- [x] Test the change in your own code. (Compile and run.)
- [x] Add or edit tests to reflect the change. (Run with
npm test.) - [x] Follow the advice from the readme.
- [x] Avoid common mistakes.
- [x] Run
npm run lint package-name(ortscif notslint.jsonis present).
Select one of these and delete the others:
If changing an existing definition:
- [x] Provide a URLs to documentation or source code which provides context for the suggested changes:
- https://github.com/openpgpjs/openpgpjs#encrypt-and-decrypt-string-data-with-pgp-keys
- https://github.com/openpgpjs/openpgpjs/releases/tag/v3.0.0
- https://github.com/openpgpjs/openpgpjs/blob/master/src/key.js#L1270
- https://github.com/openpgpjs/openpgpjs/blob/master/src/cleartext.js#L155
- https://github.com/openpgpjs/openpgpjs/blob/master/src/cleartext.js#L218
- https://github.com/openpgpjs/openpgpjs/blob/master/src/message.js#L697
- [x] Increase the version number in the header if appropriate.
- [ ] If you are making substantial changes, consider adding a
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.
It got merged really fast and now my name is part of the authors
I found this bigger than the one I did for Babel:
Bumped lodash version
#7895
po5i
posted on
| Q | A |
|---|---|
| Fixed Issues? | No |
| Patch: Bug Fix? | No |
| Major: Breaking Change? | No |
| Minor: New Feature? | No |
| Tests Added + Pass? | Yes |
| Documentation PR | No |
| Any Dependency Changes? | Yes |
| License | MIT |
Bumped lodash dependency version due to a known vulnerability described here: https://nodesecurity.io/advisories/577
Happy coding!
Top comments (0)