Overview
This week, we are planning to release Telescope 2.5, everyone has their own PRs to deal with. My issue was modifying the build log page in the dashboard to a better UI which is more understandable for users.
Progress
My first mistake that took me hours to tackle was not rebasing the newest master
branch. My old version did not have the header in the build log so I was lost. After talking to the Telescope group in slack, the problem was solved. My professor also gave me the status
links to test locally, this made everything way more easier.
In build-log/api.js
, I added a new condition to the checkBuildStatus
.
if (!data.current && data.previous) {
return {
building: true,
previous: true,
title: data.type,
githubData: data.previous.githubData,
startedAt: new Date(data.previous.startedDate),
stoppedAt: new Date(),
result: data.code,
};
}
If the status
returns previous data and there is no current data, checkBuildStatus
will return the previous data instead of building: false
.
I also had to modify views/builds.hbs
to create a new title if there is a previous build. This means, in build-log/build-header.js
, I had to add on another if condition to create a message for the previous build
if (previous) {
buildPrevious.innerText = 'Previous Build';
}
After all, my code worked and I submitted the PR. My PR got reviewed by my professor, some other open source students and the Sheriff. Everything was good and I just needed to rebase and merge it to the master branch.
Discussion
A have small discussion about React Native. The idea was creating the mobile version of Telescope using React Native. I have worked with React Native once and I loved it. If someone is willing to lead the React Native project in Telescope, I will definitely join his/her team.
Plan for next week
I have 2 issues for next week:
https://github.com/Seneca-CDOT/telescope/issues/2676
https://github.com/Seneca-CDOT/telescope/issues/2296
They are related to the sign up component that has been turned off. I need to talk to Duke for more details but at the moment, I need to finish my other assignments since they will be due this week so I will take a look at both issues next week.
Top comments (0)