DEV Community

Discussion on: 10 Lessons Learned Conducting Code Reviews

Collapse
 
mgan59 profile image
Morgan Craft

Great Article šŸŽ‰

Thought I'd add, for step #5 use a pull-request checklist in every repository that encapsulates all those various items. That is a good list for a nodejs/react library. I'd customize for each repo dependent on languages. Lastly, make sure there is a section considering security and risk, again these should be repo dependent.

Collapse
 
jnschrag profile image
Jacque Schrag

Thank you so much!

That is an excellent addition! And I'll admit, not something I had even thought about. But a checklist included in the repo is a great way to make sure you're not forgetting any of the steps. You could do the same to keep track of the required components of a pull request too.

Collapse
 
mgan59 profile image
Morgan Craft

put it in .github/PULL_REQUEST_TEMPLATE.md for it to auto-populate. šŸ˜„