DEV Community

loading...

Discussion on: Making babies, emotions and code reviews

Collapse
loujaybee profile image
Lou — Cloud Engineer

Nice article Lorenzo! :)

I also personally add "MoSCoW" ratings to my PR's. I've found since adopting this habit I've seen less friction in code reviews. Something about adding [COULD] or [SHOULD] before a comment seems to diffuse tensions especially when making slightly more pedantic requests, "trivialities" as you call them :). I think it's better to give the small comment but allow the writer to know it's optional / not that important then they are more likely to add it themselves in future.

Collapse
lpasqualis profile image
Lorenzo Pasqualis Author

Yes, that is a very good suggestion! Details like that matter!!