Discussion on: I created an easy way to browse & find Google books (today is my birthday 🎈)

View post

Replies for: That's Awesome! I got lost here as well: liyasthomas.github.io Really cool work! Could not help but notice a lot of UI similarities in your proje...

I currently don't use any 3rd party libraries. Just pure JavaScript, HTML & CSS. Of course I reuse most of my components, especially light/dark mode toggle, font stylings etc.

Ahmed Musallam • Jul 12 '19

I was looking at github.com/liyasthomas/books/blob/...

A lot of awesome things in there. and only 8KB unzipped or minified!

While inspecting the source I saw that

.category {
      height: 25vh;
}

Curious why you picked vh vs other units in this case?

I know users wont do this, but when shrinking the view-port height the title inside .category pops out :)

Liyas Thomas • Jul 12 '19

Nice you noticed that. What you explained is a bug/issue for sure.

But, sometimes some bugs are beautiful. At some use cases most of my apps would fail. But I don't mind that. Nothing is perfect. I'll certainly look into it and make it more better. Will add more bugs to fix later 🤪

Ahmed Musallam • Jul 12 '19

hahaha. I was more curious about the vh and the use-case for using it than to report a bug that almost no one will notice.. lol 😁

Liyas Thomas • Jul 12 '19 • Edited

As vh and vw changes with viewports, I like the ratio or say the proportion of UI more than giving a fixed unit. That's why I did that.

Ahmed Musallam • Jul 12 '19

I see, makes sense. thanks and keep on rockin' !