DEV Community

Discussion on: How to tell a Junior Dev that what they've done is wrong?

Collapse
 
leob profile image
leob • Edited

I know of one example from a company where I worked and we just had to let the person go after a week, it was unbearable, lol ... if the junior is any good then they will ask THEMSELVES (proactively) "do you think I did anything wrong - if so, please do tell me!"

So the answer to the question posed in the title would be: you'd just tell them straight to the point, because that's exactly what they'd want.

And if they're good then intuitively they'll ask for advice BEFORE they're about to make any egregious mistakes, and thus avoid those.

Of course people can make mistakes, but if someone needs continuous handholding and they're not proactive and don't have the intuition that something might not be the right choice or approach, yeah then you'd have a problem.

Collapse
 
nombrekeff profile image
Keff

Cheers, thanks for taking the time to help out! I much apreciate it.

This gives me a bit of prespective, and it's something that's always on the back of my mind. Though I always give people a couple of chances before going to that extreme. Always hard to deal with this stuff innit?

Collapse
 
leob profile image
leob • Edited

I can understand that it might be hard but I'm always frank (trying not to be blunt, lol) ... a good junior is eager to hear the truth coz they wanna improve ... you don't need to be harsh or mean but no need to sugarcoat it TOO much, just tell it like it is, and a good junior will even appreciate it - coz they wanna improve ... I mean, if nobody's telling them things just the way they are, then how can they improve?

Thread Thread
 
nombrekeff profile image
Keff

That's exactly what they told me when I asked them what inhu adviced, asking them how they prefer to receive constructive criticism.

It's the same case as, how will I know if I snore if nobody tells me. Or that my breath smells like crap if nobody says so!

Thanks again!

Thread Thread
 
leob profile image
leob

Haha okay ... well you hit the nail on the head - it should be CONSTRUCTIVE criticism, it should not be about putting someone down or denigrating them, it's only about the work they've done and what they've produced - with the explicit goal for them to learn and improve.

Thread Thread
 
nombrekeff profile image
Keff

That's it, the goal is to learn and improve! And that they know that's the goal too!

Collapse
 
shikkaba profile image
Me

Sometimes there are people who don't know they are doing something wrong unless they are told, and they ask what they can work on and get vague answers. I'm in this position with myself. Had something happen once and was told to fix it, but not directed how to do so. I like to at least be pointed in the right direction if it is something I didn't know in the first place.

Collapse
 
leob profile image
leob

Well in that case it's the "senior" who's the one who's clearly falling short, obviously it's not always the junior's fault! :)

Collapse
 
nombrekeff profile image
Keff

Thanks for your view, it's interesting to understand the point of view from the other side!!