This week we carries on our spirits from our last week and made two new contributions.

Issue #1 - ip2d

Again like last time, I will start with a dud. ip2d is a javascript library which is used to perform conversion on the IP addresses. My issue was not concerning the functionality of the app but to implement a pre commit hook that will do checks. The check we wanted to do was linting. This will make sure that the new changes in local are abiding with the linting rules before the commits are made. While this was a small issue to work on, it still was very interesting to me because I never interacted with pre commit hooks before, and learning it was a rabbit hole for me. I looked at different frameworks like lint staged, left hook and husky. After trying all, I found that husky was the coolest and had a big room for expansion in case there were more things added to the pre commit hook. I think this was a great learning experience and I will implement this pre commit in all of my repos to save some the linting commits later in the PR.

Issue #2 - Chat Craft

If you read my previous blog, you already know what chat craft is, this will be my second proper contribution to chat craft. In this issue we were removing the RSS feature completely from the app. I started off with removing the icon in the header responsible for the triggering of the rss page. I was not sure if the function that were responsible for the RSS pages were to be removed, to learning from my mistakes in my previous contributions I just asked.
I started by pushing everything and making a PR. I asked a question there. Turns out I was supposed to remove the function. I was under the impression that I am supposed to remove everything in the function folder and I just did that. But I was wrong, I only was supposed to removed the code block in the function folder that was specifically responsible for the RSS feed. This was pointed out in the PR and was a little embarrassing. I should have checked before I flushed out the code. Well I then got everything back and removed the code I thought was responsible for the RSS feed gen. All of my. changes are pushed now.

Conclusion

This one was a little tuff because I had to do a lot of digging to understand what parts I can remove and what needs to stay. Making that decision without being aware of all of the functionality of the app is more difficult that I thought. Also ask when in doubt rather than removing everything you deem unnecessary lol.