DEV Community

Discussion on: Mistakes I made in code reviews and what I do now

Collapse
 
kamo profile image
KAIDI

Nice post , how you manage your time to respect all what you explain here? because I think it needs time to search best explanations for every case

Collapse
 
djamaile profile image
Djamaile

Seniors get more time to do code reviews. Some even block time to do only code reviews. At least, that’s how I experienced it.

Collapse
 
wceolin profile image
Will Ceolin • Edited

@kamo Thanks! I'm glad you liked it! As @djamaile mentioned, I usually block a couple of hours per day for code reviews. But with time, some things become easier and more intuitive to see, so it's not that time-consuming anymore. By not nitpicking, we actually save time on code reviews.

Tbh, I usually don't do that much research seeking "the best explanation". If I'm not seeing a bug, I just trust my colleague has done their job well. If there's something that requires more research, I just point out some possible issues, so we can brainstorm together. I think having an honest, transparent conversation is the key here.