Wow. I loved the blog. Especially where you explained, "How to review Pull Requests?". What an explanation. You have covered almost everything. Right from the documenting the pull request to merging.
Also, I am willing to discuss/add a few more points about creating a pull request. Did you forget to talk more about the points following image has? Or you don't want this to be part of the blog? I don't know. :D
So,
Reviewers - Reviewers are those people who are going to review your pull request. You can request more than one review to the pull request.
Assignee - Assignee is someone who is currently working on the pull request. There can be more than one assignee.
Labels - Labels are the best way to add identification to the pull request. Github has already given important labels. Such as - bug, enhancement, feature, wontfix, help wanted, etc. So that other collaborators can identify the pull request without even opening.
Projects - This is where you can tag a project which you have already created.
Milestones - By adding milestones you can track and filter your pull requests. You can find a detailed description over here.
Thanks much! And I appreciate your efforts for adding more knowledge about writing code reviews. Cheers!
Hey glad you liked it. Haha yeah I intentionally left that bit out as the post was already getting too long, also GitHub has so many cool features for PR's that one post won't fit everything. Although I'm glad you added it as most readers would go through comments.
Also, there is so much more I want to share, probably a part 2 article should be written. Hmmm time for more weekend work 💃
Wow. I loved the blog. Especially where you explained, "How to review Pull Requests?". What an explanation. You have covered almost everything. Right from the documenting the pull request to merging.
Also, I am willing to discuss/add a few more points about creating a pull request. Did you forget to talk more about the points following image has? Or you don't want this to be part of the blog? I don't know. :D
So,
Thanks much! And I appreciate your efforts for adding more knowledge about writing code reviews. Cheers!
Hey glad you liked it. Haha yeah I intentionally left that bit out as the post was already getting too long, also GitHub has so many cool features for PR's that one post won't fit everything. Although I'm glad you added it as most readers would go through comments.
Also, there is so much more I want to share, probably a part 2 article should be written. Hmmm time for more weekend work 💃
Haha. Okay. COOL. B)