DEV Community

Jai Bhullar
Jai Bhullar

Posted on

Please review my project

I have used Nextjs and tailwind to independently complete the Devjobs project from Frontend Mentor. Is anybody able to take a look at project and/or code and give me any feedback? I am a learning.

Deployment: https://nextjs-devjobs.vercel.app/

Github: https://github.com/JaiBh/nextjs-devjobs

Figma: https://www.figma.com/design/h3TpBpLD7mAGDGDOdSQdNM/devjobs-web-app?node-id=0-1&t=HarRjLcCMcj1M8kA-1

Description: Small application displaying a list of developer jobs. This list can be filtered. The data is stored locally.

Some small things I plan on fixing:

  • When user clicks on "load more", the user is jumped up to the top of the page.
  • Change theme toggle from a button to a toggle.
  • Sometimes the form for filtering jobs does not reset when page refreshes.
  • I plan on storing the jobs on a database instead of local

Top comments (11)

Collapse
 
mithunsreeram profile image
MS

Hi Jai , If possible try to utilize the space around and try to make it somewhat more responsive

Collapse
 
ben profile image
Ben Halpern

Very clean, well done.

The pagination seems confusing or maybe broken.

I'd probably avoid infinite scroll on something with filtering like this. It's actually hard to tell which it is supposed to be because it's maybe a bit buggy. But either way, go with pages. Will be simpler to maintain as well.

Collapse
 
anmolbaranwal profile image
Anmol Baranwal

Hi Jai, just add the tag #discuss, which will be targeted to the whole community. Only for discussion-type posts. As for feedback:

1) I don't like the system in dark/light mode because I have to click twice to change the theme. Just set it to dark or light maybe.

2) Instead of having a "load more" button, just display the content when the user reaches the end of the list (or you could ask for this preference through a toast notification).

3) The company website (below the name) in the inner menu is still just plain text. Maybe add an icon and link it so we don’t need to copy-paste it.

Anyway, I thought to provide some feedback. Have a great day :)

Collapse
 
mukesh_singhania_1992 profile image
Mukesh Singhania

Yes probably using a better hashtag is a better way to get engagement from the community

Collapse
 
anmolbaranwal profile image
Anmol Baranwal

It's not about better hashtag actually but discussion type posts are generally recommended to have #discuss. Otherwise nobody would comment on those...

Collapse
 
shricodev profile image
Shrijal Acharya

Overall, you've built a great project. Here are a few things I noticed briefly:

  • The theme toggle button icon becomes invisible when hovered over.
  • You might want to consider adding a loading animation to the Load More button, as it provides feedback, especially for users with slow internet connections.
  • The Full-Time Only button lacks keyboard compatibility. Pressing Enter should check or uncheck the button.
  • On larger screens, the icon doesn't seem to fit well with the curved design of the white background.

Image description

  • The font is not quite visible on dark theme.

Image description

  • In the input button used to filter jobs, fit the icon inside the text box, as the ring of the input box doesn't cover it, making it look quite odd.

Overall you've done a great job buddy 🤗. If you feel these advices are worth implementing, do give it a shot.

Collapse
 
wadecodez profile image
Wade Zimmerman

i'd r8 5/8

Collapse
 
ammar629 profile image
ammar629

Pagination is not working properly
The user shouldn't be forced to scroll down again after clicking "Load More"

Collapse
 
coinvest518 profile image
Omni Ai

Very simple i would say.

Collapse
 
tn_decor profile image
TN_Decor

like

Collapse
 
w3vish profile image
Vish

i'd r 8/10

i love your font selection and typography of job details text content.

but this site is not responsive :(

Some comments may only be visible to logged-in visitors. Sign in to view all comments.