The poll results are grey on grey in dark mode, for what it's worth.
I would have thought step one would have been embedding Google forms or some other poll service and then rolling your own, but you do you :P
I prefer the inline way to make it clearer what will be in the finished article, though what would happen to results if I add an option later or completely edit the existing options like:
{% poll %}
Do you like kittens?
- Yes
- Also yes
{% endpoll %}
edited to
{% poll %}
Who is the best ruler ever?
- Pol Pot
- Hitler
- Other
{% endpoll %}
I'll get the dark mode color issues fixed in a next push.
And yeah, I think once a post with a poll is saved, it should not be possible to edit it.
From an implementation details perspective, the poll would be committed as a record in the database upon publication and not before that, and once published the whole post would not be editable (with a big message warning of this fact). This would help keep both the poll consistent but also ensure the context around the poll doesn't change. So you couldn't this scenario where:
Kittens are great.
{% poll %}
Do you agree?
- Yes
- No
{% endpoll %}
Becomes:
Drowning kittens is great.
{% poll %}
Do you agree?
- Yes
- No
{% endpoll %}
The poll results are grey on grey in dark mode, for what it's worth.
I would have thought step one would have been embedding Google forms or some other poll service and then rolling your own, but you do you :P
I prefer the inline way to make it clearer what will be in the finished article, though what would happen to results if I add an option later or completely edit the existing options like:
edited to
I'll get the dark mode color issues fixed in a next push.
And yeah, I think once a post with a poll is saved, it should not be possible to edit it.
From an implementation details perspective, the poll would be committed as a record in the database upon publication and not before that, and once published the whole post would not be editable (with a big message warning of this fact). This would help keep both the poll consistent but also ensure the context around the poll doesn't change. So you couldn't this scenario where:
Becomes:
(Sorry for the disturbing visual)
Poor kittens 😿
Sounds like the feature's thought out 👍 Looks like a solid idea :)
No kittens were harmed in the making of this feature