I have this idea of making a checklist for our developers so we can keep our engineering standards high. Currently the checklist is pretty slim and...
For further actions, you may consider blocking this person and/or reporting abuse
I think you should check out Codacy. We use it at our current company and I almost love it. I love the concept of it for sure.
It implements code linters and static analyzers on every PR you have so it looks for a lot of the things you have above. Certain things obviously you can't catch with it and need a human touch still, such as the test edge cases though.
Its nice because it allows the person doing the PR to no have to look through all the BS parts of a PR. They only have to focus on things that a linter or analyzer can't catch. Also when it complains that there is a mistake in the PR, it links to education about the mistake so that the developer grows. Its basically free mentoring on the easy stuff, which is the part I love!
I feel there has to be some kind of PR checklist integration for github but I haven't found one. That said I've put in very little effort looking.
The only problem with Codacy is that sometimes it takes a while to get a PR analyzed, like a few hours. Its gotten a lot better recently, but that's one of the pain points.
Thanks! I'll look into it.
Yeah, let me know if you end up using it!
Have you considered running any kind of CI/CD service? That's basically almost everything you mentioned. There are different approaches for almost every language out there.
Enforce different rules through code linters, practice checkers and tests. Enforce a rule of never decreasing code coverage. Only merge PR after everything passes.
Ideally, your development process should look something like this (I have no idea what is your stack, let's take a small open-source Rails project as an example):
rake testRunning this cycle even with smaller projects can greatly benefit your code style. If you do it on a regular basis, the "oh my god, another check failed again" will turn into writing code that is initially clean and easy to maintain.
We are indeed working with CI/CD and following the same best practices as you mentioned. The checklist is meant for the reviewer as a guideline for his/her review. Even with massive automation tools code review is still needed
Use a specific code style, and make everyone follow it. This could be implemented by a formatter to lift the burden off the devs.