This week, I created my first merge request in our internal gitlab. We've been using gitlab for a few weeks now, so it's quite new. Also we don't have a code review culture in our team, we just trust each other to write reasonable code.
So when I changed an important feature ("updating a document means overwriting the content BLOB" becomes "updating a document means creating a new content BLOB") I wanted my colleague to review my changes. It turned out to be difficult because I changed some lines here and there, I did not even wrote a new method.
So how do you do review such changes based on a diff? Much of the context is missing!
I also tackled some defects and wrote some integration tests that increased our code coverage. Yeah!
And how do I use this giphy-link?
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
This week, I created my first merge request in our internal gitlab. We've been using gitlab for a few weeks now, so it's quite new. Also we don't have a code review culture in our team, we just trust each other to write reasonable code.
So when I changed an important feature ("updating a document means overwriting the content BLOB" becomes "updating a document means creating a new content BLOB") I wanted my colleague to review my changes. It turned out to be difficult because I changed some lines here and there, I did not even wrote a new method.
So how do you do review such changes based on a diff? Much of the context is missing!
I also tackled some defects and wrote some integration tests that increased our code coverage. Yeah!
And how do I use this giphy-link?