DEV Community

loading...

Discussion on: My code review checklist

Collapse
elvezpablo profile image
Paul

Do you find there are still debates over things like tabs and spaces with linters in place? I feel like linters have fixed that issue for the teams I've been on.

Collapse
geekgalgroks profile image
Jenn Author

Linters do help. It is easier to take feedback from an "impartial" linter on spacing than a human. But I have seen the debate continue even with linters with teams that use multiple languages or frameworks.

Most of the time it comes back up when working with old code. Do you rewrite everything to meet the new standards or just the section you are fixing? If the policy isn't explicitly written out, it can get ugly.

Collapse
elvezpablo profile image
Paul

Good point. While I personally don't get to attached to the formatting I have heard others express that linters feel dictatorial. I could see how a human touch when doing a code review and an agreed-upon standard as a backup helps keep the debates at bay. Thanks!