DEV Community

loading...
Cover image for dev.to Repo Recap from the Past Week
The DEV Team

dev.to Repo Recap from the Past Week

Andy Zhao (he/him)
uh oh where'd my bio go!
・4 min read

Welcome back to another Repo Recap, where we cover last week's contributions to dev.to's repository and the iOS repo. This edition is covering February 3 to February 9.

Features

Bug Fixes / Other Contributions

  • @maestromac refactored our tests, and made our tests pass more reliably.

  • @jpachitas resolved a small bug where posts with gists pulled from a Medium RSS feed would sometimes fail. Thanks, @jpachitas !

  • @rhymes removed a duplicate husky configuration. Husky is a tool we use to check files before it is committed. Thanks, @rhymes !

  • @glennmen added the algorithm to reward the 3 year anniversary badge automatically. Thanks, @glennmen !

  • @aligoren fixed a small CSS issue where the "EDIT POST" button was too close to the profile image. Thanks, @aligoren!

  • @vaidehijoshi fixed our Skylight badge so it points to the now public URL! More details in our post below about how we use Skylight. Thanks, Vaidehi!

  • @rhymes updated our Rubocop configuration to match our Ruby version and use safe autocorrect in our pre-commit hook. Thanks, @rhymes !

  • We've updated our terms with a new content policy. Check it out in the terms page or the PR below. PR by @peter:

  • @ben made some optimizations to how we fetch new posts via RSS:

  • @ben also added two new timestamp columns to avoid an extra fetch: profile_updated_at and github_repos_updated_at. PR below:

  • @lightalloy fixed a bug that has been affecting our background jobs and memory usage, and started the process of moving our jobs into Rails' ActiveJob. Thanks, Anna!

  • @seanmfox fixed an issue where the v1 editor would not preview properly if you belonged to an organization and had not set any colors for your organization. The solution was to set default colors for organizations. Thanks, @seanmfox !

New Issues and Discussions

  • @kayis reported a bug where the editor switched versions and deleted text. Not a fun bug indeed. 😞 Thanks, @kayis !

Editor switched versions and deleted text #1733

Describe the bug

I wrote an article and pressed preview and suddenly had a new version of the editor, but the top half of my article was gone.

I had the impression this was some UI glitch and pressed save draft, but this just persisted the missing content.

It wasn't a long article and I just wrote it again, but it was kinda surprising behavior.

To Reproduce

I couldn't reproduce the issue, but this is what I did when it happened:

  1. Wrote a new article with the old editor
  2. Pressed did some previews and saves
  3. Pressed preview and got a new editor with missing content

Expected behavior

dev.to shouldn't switch editor mid-edit.

Desktop (please complete the following information):

  • OS: Windows 7
  • Browser: Firefox Quantum
  • Version: 66.0b4 (64-bit)

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]
  • @vorillaz requested a feature where we integrate Webmention. More details in the issue. Thanks, @vorillaz !

Add webmention integration. #1736

Hello there, great work and I instantly fell in love with the community and your efforts. As a publisher myself to dev.to, I would love to have feedback on my content as it is cross-posted to dev.to.

It would be great if you could integrate webmention.io. It requires as little as adding a tag to the HTML head and authenticate your authority using your twitter account. Thanks in advance for your efforts :)

  • @lightalloy reported a bug where nonexistent podcast episodes appear in the search results. Thanks, Anna!

Nonexistent podcast appears in the search results #1741

Describe the bug The first podcast on the page returns 404.

To Reproduce Steps to reproduce the behavior:

  1. Go to the homepage
  2. Type "books" in the search input and submit
  3. Select "Podcasts" in the left menu.
  4. Click the first result (Episode 064 – Favorite Programming Books), see "Not Found"

Screenshots book_podcasts

  • @jess made an issue as a reminder to finalize the comment templates feature. Check out the latest post that uses it here:
  • @peter reported a bug where the sidebar in mobile Android is able to scroll past the last section:

Key Links covering main feed on mobile #1746

This is from an email into yo@ and the submitter has not provided additional info, so unfortunately we are light on details.

Describe the bug It appears that the Key Links area is covering the main feed.

To Reproduce Unclear. This appears to be an Android device. If anyone else is experiencing the issue, that will be really helpful.

Screenshots screenshot of issue on mobile

Number of views doesn't change #1765

Hi,

I found something strange for my number of views.

I have the same number of views (user: @sandordargo , views: 156) for my last three posts.

The last one is strange, it hasn't changed for like two days, while the number of reactions are going up and it was featured on twitter as well. I don't think that the number of reactions can go up without the number of views also going up.

Thanks for having a look.

Cheers

  • @qm3ster requested a feature where we don't convert SVGs with Cloudinary. There's a current discussion going (started by me) about how to sanitize an SVG. Thanks for the issue, @qm3ster ! Leave any thoughts below:

Don't convert SVGs with Cloudinary #1767

Is your feature request related to a problem? Please describe. I used a vector svg image as a cover_image of a post today. It got "optimized" by Cloudinary, and served with automatic format (f_auto). This resulted in not only making it a 6.2KB webp (and even larger png) but also making it blurry. The original image was 781 bytes on the wire.

Describe the solution you'd like If possible, we'd serve sanitized svgs.

Describe alternatives you've considered I suspect if I convert it to png myself it might be less blurry, I may try that later. (Also with white background instead of transparent, since that causes a gray background on DEV.to)

  • @jeoxs reported an issue where the whole page lags when the sidebar(s) is/are opened. Check out the issue for an ongoing discussion. Thanks, @jeoxs !

Website lags when I open the sidebar (each one) #1771

Jeoxs avatar
Jeoxs posted on

I recently wrote an article about this particular issue asking people if they had the same problem: https://dev.to/jeoxs/is-it-just-my-phone-or-devto-is-heavy--1h9l

The site starts freezing when I open a sidebar. I have a Samsung Galaxy S5 mini with Android 6.0.1 and latest Chrome and Android web view versions. At first I though it was my phone but others users have confirmed the issue on their devices, too.

Thank you in advance for your support :)

The last issue I'd like to include is an issue from the Weekly Digest Bot. For the most part, it's been a bit finicky and doesn't work all the time, but for three weeks it's been posting properly! It essentially creates an issue with a list of lots of everything that happened in our repo:

Weekly Digest (4 February, 2019 - 11 February, 2019) #1783

Here's the Weekly Digest for thepracticaldev/dev.to:


ISSUES

Last week 53 issues were created. Of these, 30 issues have been closed and 23 issues are still open.

OPEN ISSUES

πŸ’š #1773 Include Article ID in Bottom Content Cache Key , by mstruve πŸ’š #1772 Save post when user press cntrl + s, by sarthology πŸ’š #1771 Website lags when I open the sidebar (each one) , by Jeoxs πŸ’š #1770 Pressing publish multiple times creates dupe posts, by whoisryosuke πŸ’š #1769 Tag template doesn't always work, by Glennmen πŸ’š #1767 Don't convert SVGs with Cloudinary, by qm3ster πŸ’š #1766 [WIP] Reduce the number of sql queries for articles comments #1606, by lightalloy πŸ’š #1765 Number of views doesn't change, by sandordargo πŸ’š #1762 Organization Notifications, by Zhao-Andy πŸ’š #1761 Added tag support to markdown editors in article posts and comm…, by deadlybyte πŸ’š #1760 Error Github PR Embed, by Glennmen πŸ’š #1758 Duplicate RSS entries on https://dev.to/feed, by IvanDelsinne πŸ’š #1748 Automatically add tag moderators to mailchimp list, by jessleenyc πŸ’š #1746 Key Links covering main feed on mobile, by pkfrank πŸ’š #1745 Add split test for landing page, by benhalpern πŸ’š #1744 Bump jest from 23.6.0 to 24.1.0, by dependabot[bot] πŸ’š #1743 Refine/Finalize Comments Template, by jessleenyc πŸ’š #1741 Nonexistent podcast appears in the search results, by lightalloy πŸ’š #1739 Display tag moderators on tag page, by seanmfox πŸ’š #1736 Add webmention integration., by vorillaz πŸ’š #1734 Do not send email on /internal/reports with 'enter' button, by jessleenyc πŸ’š #1733 Editor switched versions and deleted text, by kay-is πŸ’š #1724 Bump sail from 1.5.1 to 2.1.1, by dependabot[bot]

CLOSED ISSUES

❀️ #1768 Update Bundler to 2.0.1 & misc, by maestromac ❀️ #1764 Set default colors for organizations, by seanmfox ❀️ #1763 Add html_variant split testing to /badge, by benhalpern ❀️ #1759 Make Spotify and generic Liquid tags more strict, by Zhao-Andy ❀️ #1757 Fix profile cache leak issue, by benhalpern ❀️ #1756 Check for user exists in additional content box fetch, by benhalpern ❀️ #1755 Ping comments to pre-warm new comment trees, by benhalpern ❀️ #1754 Add profile_updated_at and github_repos_updated_at to avoid extra fet…, by benhalpern ❀️ #1753 Update DigitalOcean links/tagline, by pkfrank ❀️ #1752 RSS feed optimizations, by benhalpern ❀️ #1751 Update terms with content policy, by pkfrank ❀️ #1750 Improve performance for additional content boxes and tags index, by benhalpern ❀️ #1749 The issue 'Styling of Edit Post button on your own post' fixed. Close…, by aligoren ❀️ #1747 Enhance Internal Index Pages, by jessleenyc ❀️ #1742 Allow dashboard view for admins and update permissions in internal/users, by jessleenyc ❀️ #1740 Styling of Edit Post button on your own post, by sarthology ❀️ #1738 Add title to badge images, by rhymes ❀️ #1737 Change feature tests to system test, by maestromac ❀️ #1735 Sometimes importing posts with gist from medium via RSS does not work, by jpac-run ❀️ #1732 Added 3 year anniversary badge, by Glennmen ❀️ #1731 Additional --theme-container-color, by Link2Twenty ❀️ #1729 Bump prettier from 1.16.1 to 1.16.4, by dependabot[bot] ❀️ #1728 Bump eslint from 5.12.1 to 5.13.0, by dependabot[bot] ❀️ #1727 Bump eslint-plugin-jsx-a11y from 6.2.0 to 6.2.1, by dependabot[bot] ❀️ #1726 Bump @webscopeio/react-textarea-autocomplete from 2.3.5 to 4.2.3, by dependabot[bot] ❀️ #1725 Bump twilio-video from 1.15.0 to 1.15.1, by dependabot[bot] ❀️ #1723 Bump eslint-plugin-import from 2.15.0 to 2.16.0, by dependabot[bot] ❀️ #1722 Bump lint-staged from 8.1.0 to 8.1.3, by dependabot[bot] ❀️ #1721 Bump cloudinary from 1.9.1 to 1.11.1, by dependabot[bot] ❀️ #1720 Bump parallel_tests from 2.27.0 to 2.27.1, by dependabot[bot]

LIKED ISSUE

πŸ‘ #1739 Display tag moderators on tag page, by seanmfox It received πŸ‘ x0, πŸ˜„ x0, πŸŽ‰ x1 and ❀️ x0.

NOISY ISSUE

πŸ”ˆ #1737 Change feature tests to system test, by maestromac It received 6 comments.


PULL REQUESTS

Last week, 45 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 1 pull request was opened. πŸ’š #1766 [WIP] Reduce the number of sql queries for articles comments #1606, by lightalloy

UPDATED PULL REQUEST

Last week, 12 pull requests were updated. πŸ’› #1773 Include Article ID in Bottom Content Cache Key , by mstruve πŸ’› #1762 Organization Notifications, by Zhao-Andy πŸ’› #1761 Added tag support to markdown editors in article posts and comm…, by deadlybyte πŸ’› #1744 Bump jest from 23.6.0 to 24.1.0, by dependabot[bot] πŸ’› #1739 Display tag moderators on tag page, by seanmfox πŸ’› #1724 Bump sail from 1.5.1 to 2.1.1, by dependabot[bot] πŸ’› #1682 Add Stripe Cancellation Webhook, by jessleenyc πŸ’› #1633 [WIP] Feature/autosave editor, by aspittel πŸ’› #1579 Add click-to-copy to article share dropdown, by bennypowers πŸ’› #1563 [WIP] connect open inbox , by mariocsee πŸ’› #1524 Use for article sharing, by philnash πŸ’› #1408 [WIP] Upgrade Rails to 5.2.2, by rhymes

MERGED PULL REQUEST

Last week, 32 pull requests were merged. πŸ’œ #1764 Set default colors for organizations, by seanmfox πŸ’œ #1763 Add html_variant split testing to /badge, by benhalpern πŸ’œ #1759 Make Spotify and generic Liquid tags more strict, by Zhao-Andy πŸ’œ #1757 Fix profile cache leak issue, by benhalpern πŸ’œ #1756 Check for user exists in additional content box fetch, by benhalpern πŸ’œ #1755 Ping comments to pre-warm new comment trees, by benhalpern πŸ’œ #1754 Add profile_updated_at and github_repos_updated_at to avoid extra fet…, by benhalpern πŸ’œ #1753 Update DigitalOcean links/tagline, by pkfrank πŸ’œ #1752 RSS feed optimizations, by benhalpern πŸ’œ #1751 Update terms with content policy, by pkfrank πŸ’œ #1750 Improve performance for additional content boxes and tags index, by benhalpern πŸ’œ #1749 The issue 'Styling of Edit Post button on your own post' fixed. Close…, by aligoren πŸ’œ #1747 Enhance Internal Index Pages, by jessleenyc πŸ’œ #1742 Allow dashboard view for admins and update permissions in internal/users, by jessleenyc πŸ’œ #1738 Add title to badge images, by rhymes πŸ’œ #1735 Sometimes importing posts with gist from medium via RSS does not work, by jpac-run πŸ’œ #1732 Added 3 year anniversary badge, by Glennmen πŸ’œ #1731 Additional --theme-container-color, by Link2Twenty πŸ’œ #1729 Bump prettier from 1.16.1 to 1.16.4, by dependabot[bot] πŸ’œ #1728 Bump eslint from 5.12.1 to 5.13.0, by dependabot[bot] πŸ’œ #1727 Bump eslint-plugin-jsx-a11y from 6.2.0 to 6.2.1, by dependabot[bot] πŸ’œ #1725 Bump twilio-video from 1.15.0 to 1.15.1, by dependabot[bot] πŸ’œ #1723 Bump eslint-plugin-import from 2.15.0 to 2.16.0, by dependabot[bot] πŸ’œ #1722 Bump lint-staged from 8.1.0 to 8.1.3, by dependabot[bot] πŸ’œ #1721 Bump cloudinary from 1.9.1 to 1.11.1, by dependabot[bot] πŸ’œ #1720 Bump parallel_tests from 2.27.0 to 2.27.1, by dependabot[bot] πŸ’œ #1713 Update Rubocop configuration to target Ruby 2.6 and use safe autocorrect, by rhymes πŸ’œ #1712 Remove duplicate husky configuration, by rhymes πŸ’œ #1711 Upgrade Ruby to 2.6.1, by rhymes πŸ’œ #1699 Fix ActiveRecord::RecordNotFound in Delayed::Jobs on article destroy #1621, by lightalloy πŸ’œ #1693 Improve specs, by maestromac πŸ’œ #1680 Update Skylight badge to point to correct URL [skip ci], by vaidehijoshi


COMMITS

Last week there were 32 commits. πŸ› οΈ Set default colors for organizations (#1764) by seanmfox πŸ› οΈ [Add html_variant split testing to /badge (#1763) * Add /badge html_variant

Co-Authored-By: benhalpern bendhalpern@gmail.com

Ruby 2.6.1 contains a fix for Net::HTTP

Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/a3bb0b831a5ef1ee762fdc0a2fc96a590379cc71) by dependabot[bot] πŸ› οΈ [Bump twilio-video from 1.15.0 to 1.15.1 (#1725) [ci skip] Bumps twilio-video from 1.15.0 to 1.15.1.

Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/0090ee0dbb5b9de618afd732dff09e983e534052) by dependabot[bot] πŸ› οΈ [Bump lint-staged from 8.1.0 to 8.1.3 (#1722) [ci skip] Bumps lint-staged from 8.1.0 to 8.1.3.

Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/bf3823e1645e8d4c17b5b5f857ecee1218f8d3a1) by dependabot[bot] πŸ› οΈ [Bump parallel_tests from 2.27.0 to 2.27.1 (#1720) [ci skip] Bumps parallel_tests from 2.27.0 to 2.27.1.

Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/429d35b9a16492b2ee42809cb54f72ded4464d56) by dependabot[bot] πŸ› οΈ [Bump eslint-plugin-import from 2.15.0 to 2.16.0 (#1723) [ci skip] Bumps eslint-plugin-import from 2.15.0 to 2.16.0.

Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/77d66f5423821d1f08f1505861374d84e03f78b9) by dependabot[bot] πŸ› οΈ [Bump eslint from 5.12.1 to 5.13.0 (#1728) [ci skip] Bumps eslint from 5.12.1 to 5.13.0.

Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/5f2bafb8f5b1046ec9d1d6788eb2227064dfbe7d) by dependabot[bot] πŸ› οΈ Updated gist regex to match the urls from medium. (#1735) by jpac-run πŸ› οΈ [Improve specs (#1693) * Lock erb_lint

  • Refactor moderation spec

  • Remove & replace RequestSpecHelper

  • Update uid to sequence

  • Lower the need for persistence in specs

  • Update moderation spec

  • Update shoulda-matchers

  • Enable backgroundjobs and update commenct spec

  • Fix fail specs

  • Update comment's validations

  • Remove redundent specs

  • Actually turn off DJ

  • Apply run_background_jobs_immediately

  • Remove giveawy specs

  • Create Identity spec](https://github.com/thepracticaldev/dev.to/commit/1137d6fba40893156a06c20c84d6d5cfa46e8246) by maestromac πŸ› οΈ [Bump eslint-plugin-jsx-a11y from 6.2.0 to 6.2.1 (#1727) Bumps eslint-plugin-jsx-a11y from 6.2.0 to 6.2.1.

Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/aa16cad4297a8281f26f44893841aaadbbb80209) by dependabot[bot] πŸ› οΈ [Additional --theme-container-color (#1731) * Additional --theme-container-color

Missed in initial pass

  • Additional --theme-container-color

Missed in initial pass

  • Additional --theme-container-color

Missed in initial pass

  • Additional --theme-container-color

Missed in initial pass](https://github.com/thepracticaldev/dev.to/commit/9e4d9ecac16a70cbe64c351506cecf3de5e12459) by Link2Twenty πŸ› οΈ [Bump prettier from 1.16.1 to 1.16.4 (#1729) [ci skip] Bumps prettier from 1.16.1 to 1.16.4.

Signed-off-by: dependabot[bot] support@dependabot.com](https://github.com/thepracticaldev/dev.to/commit/ed03c4cf0cf6f0bac2bc56556ff606f8c8c0ba18) by dependabot[bot]


CONTRIBUTORS

Last week there were 14 contributors. πŸ‘€ seanmfox πŸ‘€ benhalpern πŸ‘€ lightalloy πŸ‘€ Zhao-Andy πŸ‘€ pkfrank πŸ‘€ rhymes πŸ‘€ vaidehijoshi πŸ‘€ aligoren πŸ‘€ jessleenyc πŸ‘€ Glennmen πŸ‘€ dependabot[bot] πŸ‘€ jpac-run πŸ‘€ maestromac πŸ‘€ Link2Twenty


STARGAZERS

Last week there were 68 stagazers. ⭐ cnminh ⭐ ram231 ⭐ hosos ⭐ toumasuxp ⭐ thsilvab ⭐ vorillaz ⭐ devsarmico ⭐ Glennmen ⭐ drag0s ⭐ prasadambulkar ⭐ phocks ⭐ therealt3nzin ⭐ jacobboykin ⭐ ninefivetwo ⭐ digital-drifter ⭐ yan-guilherme ⭐ jpac-run ⭐ stmoreau ⭐ toshihidetagami ⭐ CarlosPGraciano ⭐ JKirchartz ⭐ ioanlucut ⭐ afurculita ⭐ ImCypher ⭐ marlomgirardi ⭐ vblaha ⭐ mrgodhani ⭐ phiniezyc ⭐ leznov ⭐ SJTUboy ⭐ togatoga ⭐ pateldevelop ⭐ nar1ta0012 ⭐ adibhanna ⭐ thescientist13 ⭐ krushndayshmookh ⭐ cDoru ⭐ tranquan ⭐ lohxx ⭐ thisBrian ⭐ danielbayley ⭐ pulkitvaishnav ⭐ omar25h ⭐ sergeyoblyakov ⭐ asheraryam ⭐ zevaverbach ⭐ ttimot24 ⭐ Tolchi ⭐ 3sanket3 ⭐ bbonamin ⭐ zxenia ⭐ esaul ⭐ mlmabie ⭐ crispincornett ⭐ http-request ⭐ yovanycunha ⭐ jeremykenedy ⭐ sammkj ⭐ mgh87 ⭐ eneim ⭐ scaint ⭐ superbderrick ⭐ whynocake ⭐ leodutra ⭐ ceod ⭐ arlandism ⭐ Butonix ⭐ andreichernov You all are the stars! 🌟


RELEASES

Last week there were no releases.


That's all for last week, please πŸ‘€ Watch and ⭐ Star the repository thepracticaldev/dev.to to receive next weekly updates. πŸ˜ƒ

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. πŸ“†

That's it for this week! We'll see if there's another weekly digest summary next week...

Discussion (4)

Collapse
andy profile image
Andy Zhao (he/him) Author
Collapse
apol0x profile image
Apol0x

Hi.
I thinks this articule has an problem with the commits counter. In my case, fron mobile I see it counting fron 1000 to 2000 over again again...
I dont know if you have the same problem.

Collapse
andy profile image
Andy Zhao (he/him) Author

It's a looping gif that starts from 1000 to 2000. :)

Collapse
apol0x profile image
Apol0x

πŸ˜‚πŸ™ˆ I did not know itπŸ™ˆπŸ™ˆ