DEV Community

loading...

Discussion on: What is a good code review?

Collapse
danimal141 profile image
Hideaki Ishii Author • Edited

Thank you for your opinion, I agree with you!

For example:

  • Discussing architecture in the team before developing might be helpful to reduce later review communication.
  • Asking a colleague while developing (before submitting a PR) might be helpful.

And I actually often adopt such approaches.

BTW, I didn't intend to write that we have to wait for review until submitting a PR
If there are unclear descriptions that cause misunderstanding in the article, please point them out, I want to improve!

Collapse
heroincommunity profile image
German Chyzhov

In my teams we often use such approach - person puts code on review before covering it with tests. This way we minimize a possible wasted effort.
However, of course for complex tasks a selected approach should be discussed with team members before diving deep into a coding.