I am a cloud application architect with 10 years' experience in software development in several languages, including Perl, Java and C#. I'm an Irishman living in Calgary, Canada. GitHub on @cubikca.
Location
Calgary, Canada
Education
BSc. Computing and Info Systems, Athabasca University
I don't think there's any specific criteria that I check off when I review code, no more than when I help someone edit their business documents. Feedback from a code review might range from "please fix your indentation" to "I think this design doesn't work very well because...", or even "this is not the best library to use to do that". And of course "I think this feature is missing" or even "this code has a bug".
I guess if I had to pick something though, business logic is more important. While technical details like the ones I mention above are important, what I'm really looking for is whether the code solves the problem in the story. Stories rarely address technical details like what library to use or what application architecture to align with, so while I would comment on the library and architecture, the review is much more focused on the business logic.
I don't think there's any specific criteria that I check off when I review code, no more than when I help someone edit their business documents. Feedback from a code review might range from "please fix your indentation" to "I think this design doesn't work very well because...", or even "this is not the best library to use to do that". And of course "I think this feature is missing" or even "this code has a bug".
I guess if I had to pick something though, business logic is more important. While technical details like the ones I mention above are important, what I'm really looking for is whether the code solves the problem in the story. Stories rarely address technical details like what library to use or what application architecture to align with, so while I would comment on the library and architecture, the review is much more focused on the business logic.
Thanks a lot for your inputs! I completely agree!!
I always end up with some reviewers, with whom code indentation is more important than the business logic.