I will share with us some tips that improved my skill in Typescript !
Typeguard
Typeguard allow you to validate the type of an object w...
For further actions, you may consider blocking this person and/or reporting abuse
Hi CodeOzz, I might be totally wrong here, because I'm a Typescript noob, but your typeguard example doesn't look like the "Typescript way" to me. Today a friend of mine twittered some Typescript wisdom so now I want to propose the following typeguard:
As I understand it my (type based) version does type-checking at compile time while your (interface based) version does type checking only at runtime? Oh, and as you can see I also changed the return type of isFish to Boolean, because I don't understand the "pet is Fish" return type.
So what do you think?
Hi Thorsten how are you ! Thank you for your comment !
I will try to explain you what is the
pet is Fish
. This none common synthax is calledType predicate
in TS, it allow us to tell to TS that your param is typed as aFish
only if your function return true.In my case I check if my object has swim methods, if it's the case I tell to TS ->
Typescript, trust me, this pet is a Fish, not a Bird
.In you code, you put an interest thing, you create a new property in order to determine the type of your object. It should be a great idea but in your case you should delete this since you have already a way to determine the type of your object, thanks to the methods
fly
orswin
, so you don't really need to add this new property !About your function, it's not a really
typeguard
, and why? it's because your are correctly checking the type but thetypescript
checker is again doubting about the type of this object since you are not usingpredicated type
!Why it can be not really usefull to use the function like this? I will show you why of course !
So if you want to use pet in the if block, you cannot really use Fish property since for TS,
pet is again a Fish or a Bird
.With the
Type predicate
, you don't have this issue:If you have any question ask me ! ;D
But when you add new type Duck you will not be able to differentiate pets and fishes from Duck just checking available methods because a Duck can both swim and fly. In that case you will have to turn to Thorsten's explicit kind of an animal.
In the case of your interface growth you will need to use another way to put in the type guard yes. But in this exemple it's overkill to use more properties
Thank you. This predicate thingy seems pretty cool indeed. 👍
I find your example of Typeguard a little problematic precisely because it is subject to fail in the case of "interface growth". Determining type based on the presence of a method looks really flaky to me. As already suggested a duck would be identified as a fish. In your example code it makes much more sense to simply check for the presence of the swim method (i.e.
canSwim()
); rather than checking against the type*.I appreciate it's sometimes hard to find simple real-world examples; but in this case you either need to find a better one or add a health warning: your
isFish
method is very likely to introduce hard to trace bugs in future and defeats the very purpose of using TS.Apart from that I found the article useful ;)
* In the same way you should prefer 'feature detection' over 'browser detection'.
Hello ! As I said in another comment the aim of this example is to understand what is a Typeguard ! My example doesn't reflect the reality since as you said, Duck can be identificated as Fish !
In a real project you should use another way to make the difference between each class :)
Thank you for your comment a lot !
Indeed; that was precisely my point: it's an ill-conceived example and demonstrates how not to use Typescript. There's little point demonstrating that functionality exists if you don't also demonstrate the thought processes required to use it properly.
This is awesome!! Thank you so much I've always wondered what some of this does in other peoples code. Now I can use it myself!
Thank you Richard ! I appreciate your comment ! If you have any question about some TS code that you don't understand, you can ask me on my twitter :)
Thank you so much!!
Thank you a lot Anjan, it's very motivating to see comment like this :)
Good article.