DEV Community


Discussion on: Code Reviews Are Awesome, Here Are 7 Reasons Why

buinauskas profile image

It's cool as long as it's working like you described. I sometimes end up in situations like:

  • Psst. I need someone to approve my PR. Can you do it?
  • Yeah sure. Approves without checking code.

Or asking to improve pending code makes someone feel guilty. But hey, then we probably have far bigger issues than just code reviews.

ice_lenor profile image
Elena Author

You're right! I think if the team/company wants to do code reviews, there has to be a process, and everyone should be responsible enough to not forgo it:). Otherwise, they can end up not testing (psst! Can you pretend you tested my feature and it works?), or not working at all (psst! Can you tell our manager I was here today?).
I mean, it might sound like I'm exaggerating, but what's the real difference?

If, on the other hand, they don't want or don't need reviewing at the current stage of the project, for whatever reason, then it should not be mandatory.

Forem Open with the Forem app