DEV Community

[2021] Setting up Husky pre-commit hook with ESLint, Prettier and lint-staged for React and React Native.

Yash Kalaria on December 09, 2019

Hello folks. I hope you all are doing well. In this post, we will talk about how you can setup Husky pre-commit hook with ESLint, Prettier and lint...

Read full post

Comment hidden by post author - thread only accessible via permalink

Kenny To • Aug 9 '20

I had dependencies issues with eslint as a devDependency, since React requires version 6.8.0. Not sure why it didn't resolve itself. Just incase anybody runs into this in the future., you can skip installing eslint and let the project manage the dependencies by itself.

Yash Kalaria • Aug 21 '21

Updated for 2021 with all the fixes.

Comment hidden by post author - thread only accessible via permalink

Prateek Maheshwari • Jun 15 '20

Just a query, you said the above code will run Prettier and ESLint rules against all js,jsx,ts,tsx files in the src directory OR will it run for all the specified files in src which are STAGED?

Yash Kalaria • Jun 17 '20

It will run for all the js,jsx,ts,tsx files in the src directory whether they are staged or not.

Prateek Maheshwari • Jun 17 '20

How can we make it run for only staged files. I am stuck with this in my project because the eslint takes too much time as it runs on all files in the directory.

Yash Kalaria • Jun 17 '20 • Edited

Try replacing your "lint" command in package.json with below command and if that works then you can do something similar for prettier too.

"lint": "eslint src/**/**/*.js --fix-dry-run git diff --diff-filter=d --cached --name-only | grep -E './**/*.(js|jsx|ts|tsx|css|scss|md)$'"

Nithin • Jun 23 '20 • Edited

Thanks for the post Yash, it was very helpful. Just wanted to point out that I don't think this is necessary. Correct me if I'm wrong, but from the lint-staged documentation and from what I see from my own project after setting this up, linting runs for only the files which are staged and also match the specified glob pattern.

"husky": {
"hooks": {
"pre-commit": "lint-staged"
}
},
"lint-staged": {
"*.{js,jsx,ts,tsx}": [
"npx prettier --write",
"eslint --ext .js,.jsx --fix-dry-run"
]
}

I used this setting and it only throws lint errors for staged changes while I commit even though there are other unstaged files with lint errors.

I think the line to note is
"eslint src/*.js --fix-dry-run" which you've mentioned.

I've used "eslint --ext .js,.jsx --fix-dry-run" without specifying a target, so that it doesn't run for all files in the src directory, only the staged files that are fed into this command by lint-staged.