DEV Community

Discussion on: What's the worst code you have seen by a senior dev?

Collapse
 
avalander profile image
Avalander

That's just an overlook. I've seen functions that are hundreds of lines long, where I have to scroll and scroll to the right because some lines don't fit in the screen and they are just chaining methods and rubbish in a so-called "fluent" API.

Collapse
 
dineshmadanlal profile image
dineshmadanlal

That's a real pain. Code reviews come handy here. Review comments like why functions with hundreds of lines could affect other devs. We should follow a strict rule of a checklist. Pull requests can be created only if the code standards follow the checklist. This makes sure code quality isn't affected. This has done wonders for our team :)