May I suggest you change the selector prefix from ng- (ng-modal), to something else? ng- is meant to be reserved for use by Angular itself. The issue is, if Angular adds a component called ng-modal internally (unlikely, but possible), your component will conflict with that. Also it is unclear whether or not this component is official or not.
Looks great, thank you for posting this.
May I suggest you change the selector prefix from
ng-(ng-modal), to something else?ng-is meant to be reserved for use by Angular itself. The issue is, if Angular adds a component calledng-modalinternally (unlikely, but possible), your component will conflict with that. Also it is unclear whether or not this component is official or not.Thanks for you feedback.
What would you suggest the for the selector name?
Well, that's the tricky bit :D
Perhaps your initials as the prefix or your github username?
siddhantdev-modal?I'll go with sj-modal 😊