DEV Community

Discussion on: What's your typical process for reviewing a pull request in GitHub?

Collapse
 
aspittel profile image
Ali Spittel

When I was teaching, students would submit their homework/labs as pull requests, which leads to reviewing a couple hundred a week. My quickest tip is the tiny command line instructions link on GitHub saves a ton of time.

I would copy and paste the Step 1 changes into the CLI and then test the code on my computer. Then, I would normally do inline comments using the plus button that pops up when you hover over a line of code in the files changed tab with things I would change or things that were awesome!

Collapse
 
jdforsythe profile image
Jeremy Forsythe

I'd add that you can now make multi-link comments (comments on multiple lines of code) which makes it much easier to provide context

Collapse
 
ben profile image
Ben Halpern

Yeah I do that too. This morning (prompting this discussion), I had the feeling that maybe I want to do this via GitHub Desktop because it just seems like the more flowy way to do it. I don't like that app much for most of my workflow, but in terms of quickly going from web to review it could be better.