Reviewing PRs in Telescope has been really interesting. I know I discussed earlier about my work with the Avatars in the GitHub information section, and I found a PR that built on the implementation for that.
For this PR, I took the time to build the application on my end locally. I additionally tried to play around and see if it would break anything (scrolling, lightmode/darkmode etc). To my surprise everything was great - and therefore was a simple approval!
The second PR I reviewed was also interesting, but required a more complicated solution. Something which I also was not too familiar with. Again, I took the time to build the application locally and play around with it. I then opened up the web and navigated to the Telescope website to see the changes. I honestly had a hard time with the color scheme for the code blocks in dark mode. Knowing myself well, I have difficulty reading on screens anyways, and had seen the repository owner had provided suggestions to stylesheets to use, and the contributor had used one of those, so I decided this was sufficient enough. After testing in light/dark mode I noticed the code blocks were changed in the lightmode too - something I was not too sure was correct. I wrote a comment about this, and the contributor was quick to respond that they were trying to find a solution for this - hence it was a draft PR. I was intrigued. I could provide a solution for this in Angular so easily, but being this was React, I went to the web to search how this could possibly be implemented - to provide some help. After providing some suggestions, the repository owner had made a suggestion to the correct approach, noting my approach would not work.
Although my review was not very helpful, I believe by contributing and exploring different issues, we always learn something. For example, eventually we did get a better suggestion on the PR. Sometimes, the easier way to learn something is through reviewing.
Top comments (0)