Continuing my progress in the Telescope repository for Release 3.0 my Search bar PR from last week got some reviews. Unfortunately, I was not really given any "feedback", aside from being told the PR was too big, and to split it up.
Hearing this was extremely disappointing. A part of myself thought I was over splitting this issue any further - yet we've managed to come across this thrice. There's no way to separate the UI from the backend anymore - the backend is all ready. So what I've done to remove the old search bar UI more easily is I have put functionality for ONLY author and post search. In another PR I can add the rest of the fields (i.e. title, dates).
In my new PR, instead of tackling all four issues, I only decided to tackle one. Which is the UI for the search bar. In this PR, I will address new UI for the existing fields. In the second PR, I can address issue 2894, where we can search by new fields, date and title. Both of these PRs should build on the last issue, issue 2110, which is for the advanced search dialogue.
Unlike my PR for search, my previous PR for the translation services got a lot of feedback. I got a lot of feedback on my code, which was nice, but some of it was being nit-picky so I decided to put my foot down. There were a lot of complaints about the UI. I understood the issue, however, the PR was never meant to address the UI for this. I ended up creating a new issue for this. To be honest, I really do not like MUI and would prefer not to have to tackle this. We are using an older version of it, however, there is not much customization.
Top comments (0)