Is the code structured correctly and following the same trends and patterns as the rest of the application?
If it breaks from those patterns is it a good reason to do so?
Code quality
Does it follow good namig conventions?
Are FP principles used?
Are unit or integration tests are present?
If existing code is modified and it had automated tests to cover it, have the tests been updated to also check the new logic?
Maintainability
If i think certain parts are badly written or too complex, unreadable, or could be simplified I might suggest alternatives.
Note to self when reviewing code
Can you automate more to make some general mistakes occur less often?
avoid formatting comments by using a code formatter
avoid some code quality comments by using linters
discuss more upfront when a colleague has a challenging task so the outcome is more predictable (have a huddle task for complex work)
Great learnings from here. I like how you strive for codebase consistency (is this similar to what we have elsewhere) and also for automation (avoid style discussions by introducing a common linter). Thanks for sharing!
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Code structure & common patterns used
Is the code structured correctly and following the same trends and patterns as the rest of the application?
If it breaks from those patterns is it a good reason to do so?
Code quality
Does it follow good namig conventions?
Are FP principles used?
Are unit or integration tests are present?
If existing code is modified and it had automated tests to cover it, have the tests been updated to also check the new logic?
Maintainability
If i think certain parts are badly written or too complex, unreadable, or could be simplified I might suggest alternatives.
Note to self when reviewing code
Can you automate more to make some general mistakes occur less often?
Great learnings from here. I like how you strive for codebase consistency (is this similar to what we have elsewhere) and also for automation (avoid style discussions by introducing a common linter). Thanks for sharing!