Adrian Carter

Posted on Apr 27, 2022

Open Discussion: What Tips Do You Have For Writing Clean Code?

#beginners #discuss

Recently, I read an Article where the author, Jerry Low, suggested that developers write their CSS properties in alphabetical order. I think this is a great idea, and it got me thinking what some other tips for writing clean and readable code? Feel free to share your suggestions.

Top comments (31)

Christian Engel • Apr 27 '22

I read that article out of curiosity and I have to say, I am more than just a bit irritated by it.

The article is a perfect example of someone selling a personal preference as if its a fact which everyone should obey.

The autor even admits that after doing some research he found out that just about 10% of other developers follow his example and the majority does logical grouping.

I have to say, I think alphabetical oordering is just as bad as random ordering. The two examples looked exactly the same for me. I am very much in favor of the logical grouping (with blank lines in between!) and think its much easier to scan over.

But still: is is preference and not "clean code".

If you think about improving your general coding abilities, I can warmly recommend two books:

A philosophy of software design
by John Ousterhout

Refactoring (second edition)
by Martin Fowler

I learned a lot out of these two books.

Adrian Carter • Apr 27 '22 • Edited

Thanks for sharing your perspective, it's cool to read an opposing viewpoint on this article. Everyone has different personal preferences as it pertains to the way they code. After reading your comment, I can understand why the article can rub some people the wrong way.

𒎏Wii 🏳️‍⚧️ • Apr 28 '22

Don't be lazy about typing. Abbreviations harm readability.
Don't encode data in your control flow. switch/case is evil.
Don't implement what you need right now. Think in abstracts.

mephi • May 2 '22

I don't get the problem with switch case. Can you provide an example?

𒎏Wii 🏳️‍⚧️ • May 2 '22

switch/case is often abused to express data that should be a map as control flow instead. Then people wonder why their code is so hard to extend.

mephi • May 2 '22

Ok... but if I don't use Python, I can't put everything in a map.

𒎏Wii 🏳️‍⚧️ • May 3 '22

Yes, you can? What programming language doesn't support maps these days?

Jon Randy 🎖️ • Apr 28 '22

Remember "Clean Code" is subjective
Don't prioritise "cleanliness" over efficiency

𒎏Wii 🏳️‍⚧️ • Apr 28 '22

Efficiency in what sense though? Clean code is usually easier to maintain, making work more efficient.

Jon Randy 🎖️ • Apr 28 '22 • Edited

I've been in code reviews where code was rejected in favour of "cleaner" code, despite being many orders of magnitude faster. Later, clients complain about performance. Madness

𒎏Wii 🏳️‍⚧️ • Apr 28 '22

But those cases are often just a false dichotomy. Usually, it works something like this:

The naive bad solution looks clean
The naive good solution looks messy
The good solution can look clean with the right abstractions

The right solution is obviously to spend the extra time to figure out how to make the good solution actually look clean, but if you ignore that option entirely, you can claim to decide between performance and readability.

When people find problems that really can't be expressed cleanly without a massive performance loss, they're either writing a C compiler, or they haven't spent enough time looking for a better solution.

José Aponte • Apr 28 '22

I follow the 3 "make" rule when programming:

Make it run!
Make it good!
Make it fast!

The clean code will appear between the steps 2 & 3.

tq-bit • Apr 28 '22 • Edited

I recently wrote all of these rules down for myself. The document is more than 600 lines long, so here are my 3 most important tldrs. All of them are inspired by Uncle Bob's best seller.

1. Write code so it resembles its own specification

I find this the most relevant point, but also the hardest. I got the idea by combining the rule 'Use intention-revealing names' from Clean Code and 'Start Statements with Verbs' and 'Be brief' from Microsoft's writing guidelines.

A bit easier to imagine is: Write code like you write a newspaper article. A common rule here is The Pyramid Principle of writing. So all those essays in highschool were actually good for something

2. Prefer readability over performance

You might have noticed there's a pattern already. Code must be read by people, not machines. In most of the cases, the fancy JS 1-liners come with a trade-off in readability. MS writing guidelines support this - 'Write like you speak' tells you to write like a person, not a machine.

3. Do proper error handling and always do it the same way

The idea for this comes from the chapter 'Use special error objects'.

My solution is to use try-catch inside a custom function that always returns an error-tuple.

In Typescript, the type looks like this:

type TryCatchTuple<T> = [T | null, Error | null];
// Resolves in a 2-element array with [result, error]
// -> result is null if there's an error
// -> error is null if there's a result

It's used in this function (async example):

const tryCatchAsync = async <T>(fn: () => Promise<T>, ): Promise<TryCatchTuple<T>> => {
    try {
        const result = await fn()
        return [result, null];
    } catch (error) {
        return [null, error];
    }
}

For sync, just leave out the async/await and the Promise generics.

Squirrelcoding • Apr 30 '22

I don't like point #2, there's source code and compiled code. Those fancy "JS one-liners" aren't even meant to be read, they're optimized and compiled source code. Best practices and idiomatic code can lead to good readability and performance.

tq-bit • Apr 30 '22 • Edited

Maybe I've phrased myself poorly here. What I meant to say is: I'd prefer function code like this:

const numbers = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];

const doubleNumbers = numbers.map(number => number * 2);
const numbersAboveFive = doubleNumbers.filter(number => number > 5);
const numberSum = numbersAboveFive.reduce((acc, number) => acc + number, 0);

over this one:

const numbers = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];

const numbersDoubledAboveFiveSum = numbers
    .map((number) => number * 2)
    .filter((number) => number > 5)
    .reduce((acc, number) => acc + number, 0);

in more complex settings.

I've seen a 50-liner in a productive codebase during last hacktoberfest and I found it rather hard to decipher due to these constructions.

If you chain the above example to a single function called duplicateNumbersAndSumAllAboveFive, fine by me. If you do three other things along the way, you should think about refactoring. Or at least make debugging less messy.

mephi • May 1 '22

To me the second example is much easier to read, as I don't have to make the connection between the four variables on my own. I can read it like "ok, I want numbers doubled above five and summed up. I take the numbers, map to their double, filter all above 5 and apply a standard sum reduce.

tq-bit • May 2 '22 • Edited

Then let me give you another example.

The following code snippet is meant to provide state for a react component (this - context = applicationwide state). I have slightly changed the original variable names, otherwise it's the same logic.

I then gave myself 10 minutes to try and refactor the function. When I put both into my text editor and try to debug, the second function is surely easier on the eye than the first. I might be wrong though, that's just my opinion.

Original

function colorsByCategory() {
    const colorsByCategory = this.item?.colorsByCategory;

    if (!colorsByCategory) {
        return {};
    }

    const categories = {};
    const availableColors = this.initialState.permittedColors;
    const allowedColors = this.configuration.allowedColors;

    Object.keys(colorsByCategory).forEach((key) => {
        const category = { ...colorsByCategory[key] };
        const colors = category.colors
            .filter((color) => availableColors?.includes(color.colorKey))
            .map((color) => {
                color.disabled = !allowedColors?.includes(color.colorKey);
                return color;
            });

        if (colors.length > 0) {
            category.colors = colors;
            categories[key] = category;
        }
    });

    return categories;
}

My 'debugable' approach

function colorsByCategory() {
    const itemColorsByCategory = this.item.colorsByCategory;
    const availableItemColors = this.initialState.permittedColors;
    const allowedItemColors = this.configuration.allowedColors;

    return !!itemColorsByCategory ? getItemColorCategories() : {};

    function getItemColorCategories() {
        let categoryMap = {};

        Object.keys(itemColorsByCategory).forEach((key) => {
            const itemCategoryEntry = cloneEntry(itemColorsByCategory, key);
            const permittedItemColors = filterPermittedColors(itemCategoryEntry.colors);
            if (permittedItemColors.length > 0) {
                categoryMap = assignColorToCategory(categoryMap, itemCategoryEntry, key);
            }
        });

        return categoryMap;

        function assignColorToCategory(categoryMap, categoryEntry, key) {
            const localCategory = cloneEntry(categoryEntry);
            categoryMap[key] = localCategory;
            return categoryMap;
        }

        function filterPermittedColors(colors) {
            return colors
                .filter((color) => availableItemColors?.includes(color.colorKey))
                .map((color) => {
                    color.disabled = !allowedItemColors?.includes(color.colorKey);
                    return color;
                });
        }

        function cloneEntry(category, key) {
            return key ? { ...category[key] } : { ...category };
        }
    }
}

spO0q • Apr 28 '22 • Edited

To me, it's usually a triangle: Efficiency, readability, abstraction.
However, it's rarely the same distribution, as it can vary from one project to another, depending on the context. I can't give a general rule but this how I see the project in terms of clean code.

You can't neglect performances but you have to avoid micro-optimization, especially when the code becomes too "ninja", a.k.a. less readable and maintainable. If you're the only one who can modify the script, it can become a problem quickly.

Too much abstraction is not really good in my experience. It can jam code reviews significantly. Besides, you can get a lot of unwanted side effects, so more stress for maintenance, etc.

Gustavo Santos • Apr 28 '22

About the article, I feel that is more personal taste than some pragmatic thing. There is a big difference between opinion (which everyone has) and well-known metrics such as SLOC, Cyclomatic Complexity and so on.

As tips, I suggest reading those books:

As a general rules of thumb that I like to follow:

Follow Tell, Don't Ask when possible, but not become too dogmatic about that
Law of Demeter is not a law, but it helps drive the code to a good and maintainable future
Start writing acceptance (e2e) tests, then write unit/integration tests, then write the code. This helps a lot organizing ideas and communication between the parts, without writing all the base classes upfront.
ReadMe driven development help organize what to do first and this impact directly to the code organization
Know your tools, this help you to use your tools to write your code.
Use dependency injection, even if it needs to be done in a manual way.
Write code for humans, not for machine.
(questionable taste) Switch/case isn't evil. Use it in factories to help to use polymorphism
(questionable taste) Do not put repeated prefixes or suffixes, like "UseCase", "I", "Service", "Entity" and so on (unless if needed to work, like the prefix use in React Hooks). Each object should tell a story, each object should deserve its place in the source code by the story that it tells, not by its name.

mephi • May 1 '22

To me, a clean code rule has to be something that is worth the effort in the end.
I'm not that fast at alphabetical sorting, so I would take a lot of extra time and it would exceed the benefits it could provide.
My favourite type of sorting is the one my IDE does on autoformat.

taijidude • Apr 28 '22 • Edited

Imagine while coding the colleague who has to maintain the code after you is a violent psychopath who knows where you live. 😅

Volodymyr Yepishev • Apr 28 '22

The more articles I read on "clean code", the more it reminds me of a religion or a cult :)

John Colagioia (he/him) • Apr 29 '22

I have a simple, modest suggestion: Almost every programming ecosystem has tools (pretty-printers, code formatters, or code beautifiers, depending on how old your language is...) to enforce a style. Just do what they say for new code, instead of arguing about style. Don't like that style? Use the same tool, configured to whatever style that you would prefer to look at.

Seriously, after sixty years of code, we need to stop wasting time arguing over style preferences. Let cb, prettier, gofmt, rustfmt, or whatever do that thinking. The format doesn't matter, as long as everybody commits to the same standard. An exception, as hinted above: Leave the pre-beautifier code alone, until you need to change it. Nobody needs a ticket to automatically fix the indentation on a million lines of code written before they were born...

And then the time saved on arguing about format can go to fixing all the warnings that the linter keeps complaining about that you either don't know about because you're not running your linter, or have been ignoring because "it's only a warning."

View full discussion (31 comments)

DEV Community

Open Discussion: What Tips Do You Have For Writing Clean Code?

Top comments (31)

1. Write code so it resembles its own specification

2. Prefer readability over performance

3. Do proper error handling and always do it the same way

Read next

Intuitive Explanation of O(n log n) Complexity⏳

How to Ensure Your Startup Fails Spectacularly 🚀💥

Day 13: Docker Multistage Builds

Understanding Type and Interface in Typescript