This week I implemented TOML support for DocBot made by @add00_3. First time hearing about TOML and kind of surprised this exists(we already have YAML). Implementation was pretty simple since the code was written in JavaScript and the code was very easy to read. Although it did take a minute to figure out how to run the tool since I had to run the ollama model locally in order to run the tool. I had ollama installed previously but I had to install the default model that was defined. After that I implemented the feature which was pretty simple. Only "issue" I had was for this tool output flag is null by default and TOML doesn't support null so I had to add additional logic to handle this case. Aside from that it was pretty easy. Moreover, I just updated the logic to use initialized variable instead of using attributes from args directly. Surprisingly, there was no changes requested so I got it merged on the first try!
Git remote
Adding forked repo link to the current project locally was something I never did. But it was not difficult and pretty straight forward actually. Only issue I faced was after squash merging @majd_almnayer_2101's branch and pushing the main branch to remote the PR and Issue didn't close automatically. Which was frustrating. I tried to find out the reason why but couldn't find any, although the squash merge commit does reference to the PR itself, it doesn't close the PR or the Issue. Only reason I can find is I did squash commit but in order to keep a linear history I don't have a lot of choice. So I had to do it from the browser which is how it's usually done. Aside from that it was pretty simple.
Top comments (0)