DEV Community

Discussion on: Common Sorting Algorithms

View post
Collapse
 
zacharypatten profile image
Zachary Patten • • Edited
  1. You should make the algorithms work on generics.
  2. You should take in delegates/structs parameters to allow custom sorting.
  3. You should abstract them so they work on any int indexed collection (not just arrays).
  4. You should add benchmarks using BenchmarkDotNet to your article.

Here are the current versions of my sorting algorithms (with all those topics included):

Collapse
 
jjb profile image
JB •

@zacharypatten

I think some of those suggestions could be worthwhile and your repo definitely looks interesting.

Having said that, the main aim of the post, and the series in general, is to learn the concepts and write code that can be easily understood - even by developers unfamiliar with C#.

At any rate, thanks for reading and providing feedback!