DEV Community

loading...

Release 3.1 - telescope

yzwdroid profile image Andy Yang ・2 min read

For this release, I contribute to this issue https://github.com/Seneca-CDOT/telescope/issues/1351. The pull request https://github.com/Seneca-CDOT/telescope/pull/1352

This is a relatively easy issue, We need to change the environment variable MAX_POSTS_PER_PAGE. The first thing I do is search this variable in our code.
Alt Text

Three results from three files.
Here are the steps I did.

  • create a new branch with the issue number.
git checkout -b issue#1351
Enter fullscreen mode Exit fullscreen mode

Then, I set the value of this variable to 5. The coding job is done.

  • remove the old .env file, and copy the new env.example to .env
cp env.example .env
Enter fullscreen mode Exit fullscreen mode

Then test the code in my local machine. It works, we have 5 posts per page.

Problem to push the code.

When I push the code to the remote git push origin issue#1351, git gives me a warning no permission to push. I checked the remote address git remote -v. I make a mistake and clone the repo from telescope. Now the original address is https://github.com/Seneca-CDOT/telescope.git.

How I solve the problem.

If I am not in this class, I will delete everything and clone a new repo from my forked repo git@github.com:yzwdroid/telescope.git.

But I am a git master now (Thanks for @humphd), the remote repo is just a name origin. I can just add another remote with the command git remote add yzwdroid git@github.com:yzwdroid/telescope.git. Then just push the current branch $issue1351 to the yzwdroid remote repo.

git push yzwdroid issue#1351
Enter fullscreen mode Exit fullscreen mode

Then I do the pull request from github.

Discussion (0)

pic
Editor guide