DEV Community

Tengzhen Zhao
Tengzhen Zhao

Posted on

Release 0.3 code review

1. I reviewed the IPC144 Issue 124 - Build PDF in deployment and include when we publish to GH-Pages.
I checked the docusaurus-config optional fields, it seems no field support downloading the document directly if you use the links: [ {items:}]. I suggest that create a new file, e.g. the name is Seneca-IPC144-download.md. Then, fill in a back-end interface for downloading files on this page, e.g. https://codeload.github.com/douban/douban-client/legacy.zip/master.

var $btn = $("#btn");

//A back-end interface for downloading files is known:
https://codeload.github.com/douban/douban-client/legacy.zip/master

$btn.click(function(){
    window.open("https://codeload.github.com/douban/douban-client/legacy.zip/master");
});
Enter fullscreen mode Exit fullscreen mode

After that, in the docusaurus.config.js file, use the following code that can navigate to the download page.

items: [
        {
            label: 'Download',
            to: '/Seneca-IPC144-download',
         },
          ],
Enter fullscreen mode Exit fullscreen mode

2. I reviewed another issue-ASCII Collating Sequence image converted into Table
Image description
I have two suggestions, the first is that at the end of line 47, the table should display " | ", but it is blank.
The second is the page didn't display a subtitle compared with the IPC144 old version.

Discussion (0)