DEV Community

Discussion on: What's your best PR etiquette tip?

Collapse
waylonwalker profile image
Waylon Walker Author

Feels a bit like treading on eggshells, but I think that's for the best.

for sure. I somehow found myself in the position of team lead with very little of my code going through review. Now I review lots of code, so its hard for me to find words for things.

I have a bunch of linters and checkers running so pedantic stuff is already taken care of. I have been known to be very hyper focused on robustness and reliability. I am very focused on the next person being able to read, understand and change the code. If you have set the next person up to fail by connecting two things that shouldn't be or not connecting two things that should be I'll call that out.

Collapse
sargalias profile image
Spyros Argalias

Very nice. Yeah automating the little stuff makes everything better. Less time wasted on it and you can focus on the important things more.

The rest sounds like you're reviewing code as it's meant to be reviewed :)

Thread Thread
waylonwalker profile image
Waylon Walker Author

this comment made my day!