DEV Community

Discussion on: How to make your first Pull Request on GitHub

Collapse
 
tomayac profile image
Thomas Steiner

Haha, seeing this now as the author of the example article. Nice tutorial, and especially because it was a "rejected" PR, so not a "success" story. Our style guide is really good, but I admit I have to go back to it every. single. time when it comes to quotation rules…

By the way, the dark/light mode toggle on your site might be a good candidate for the <dark-mode-toggle> that is described in the article.